conf: remove unused assignment statement in virSysinfoBaseBoardParseXML

[libvirt] [PATCH] conf: remove unused assignment statement in virSysinfoBaseBoardParseXML

Wang King posted 1 patch 7 years ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20170413021643.2712-1-king.wang@huawei.com

src/conf/domain_conf.c | 1 -
1 file changed, 1 deletion(-)

Expand all Fold all

[libvirt] [PATCH] conf: remove unused assignment statement in virSysinfoBaseBoardParseXML

Posted by Wang King 7 years ago

Assigning value 0 to @nboards in success path, that stored value is not used.
---
 src/conf/domain_conf.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 80baa09..52f4c7a 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -13086,7 +13086,6 @@ virSysinfoBaseBoardParseXML(xmlXPathContextPtr ctxt,
     *baseBoard = boards;
     *nbaseBoard = nboards;
     boards = NULL;
-    nboards = 0;
     ret = 0;
  cleanup:
     VIR_FREE(boards);
-- 
2.8.3


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] conf: remove unused assignment statement in virSysinfoBaseBoardParseXML

Posted by John Ferlan 7 years ago


On 04/12/2017 10:16 PM, Wang King wrote:
> Assigning value 0 to @nboards in success path, that stored value is not used.
> ---
>  src/conf/domain_conf.c | 1 -
>  1 file changed, 1 deletion(-)
> 

ACK (and will push shortly)

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list