[libvirt] [PATCH v2 0/3] nwfilter: Create common virNWFilterObj* APIs

John Ferlan posted 3 patches 7 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20170410193544.1347-1-jferlan@redhat.com
src/conf/virnwfilterobj.c      | 103 +++++++++++++++++++++++++++++++++++++++++
src/conf/virnwfilterobj.h      |  22 +++++++++
src/libvirt_private.syms       |   3 ++
src/nwfilter/nwfilter_driver.c |  86 +++++-----------------------------
4 files changed, 139 insertions(+), 75 deletions(-)
[libvirt] [PATCH v2 0/3] nwfilter: Create common virNWFilterObj* APIs
Posted by John Ferlan 7 years ago
v1: https://www.redhat.com/archives/libvir-list/2017-April/msg00299.html

Effectively move code from nwfilter_driver.c into virnwfiltereobj to
count the number of devices, to return a list of names, and to return
an array of filters.

FWIW: This is part of the common driver objects code I've been working
through. I figured I will post each driver separately rather than one
larger series.


v2: Differences:

 - Remove memset() from *GetName
 - Change "if (aclfilter && aclfilter())" to "if (!aclfilter || aclfilter())"

John Ferlan (3):
  nwfilter: Introduce virNWFilterObjNumOfNWFilters
  nwfilter: Introduce virNWFilterObjGetNames
  nwfilter: Introduce virNWFilterObjListExport

 src/conf/virnwfilterobj.c      | 103 +++++++++++++++++++++++++++++++++++++++++
 src/conf/virnwfilterobj.h      |  22 +++++++++
 src/libvirt_private.syms       |   3 ++
 src/nwfilter/nwfilter_driver.c |  86 +++++-----------------------------
 4 files changed, 139 insertions(+), 75 deletions(-)

-- 
2.9.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 0/3] nwfilter: Create common virNWFilterObj* APIs
Posted by Michal Privoznik 7 years ago
On 04/10/2017 09:35 PM, John Ferlan wrote:
> v1: https://www.redhat.com/archives/libvir-list/2017-April/msg00299.html
>
> Effectively move code from nwfilter_driver.c into virnwfiltereobj to
> count the number of devices, to return a list of names, and to return
> an array of filters.
>
> FWIW: This is part of the common driver objects code I've been working
> through. I figured I will post each driver separately rather than one
> larger series.
>
>
> v2: Differences:
>
>  - Remove memset() from *GetName
>  - Change "if (aclfilter && aclfilter())" to "if (!aclfilter || aclfilter())"
>
> John Ferlan (3):
>   nwfilter: Introduce virNWFilterObjNumOfNWFilters
>   nwfilter: Introduce virNWFilterObjGetNames
>   nwfilter: Introduce virNWFilterObjListExport
>
>  src/conf/virnwfilterobj.c      | 103 +++++++++++++++++++++++++++++++++++++++++
>  src/conf/virnwfilterobj.h      |  22 +++++++++
>  src/libvirt_private.syms       |   3 ++
>  src/nwfilter/nwfilter_driver.c |  86 +++++-----------------------------
>  4 files changed, 139 insertions(+), 75 deletions(-)
>

ACK

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list