Allow some cross pool type source device path checks

[libvirt] [PATCH 0/4] Allow some cross pool type source device path checks

Posted by John Ferlan 7 years ago

https://bugzilla.redhat.com/show_bug.cgi?id=1233129

Refactor the virStoragePoolSourceFindDuplicateDevices code a bit to
make it a bit easier to read, then allow pool def type's that use a
pool source device to define the source device to perform cross pool
source device conflicts.

John Ferlan (4):
  conf: Introduce virStoragePoolObjSourceMatchTypeDIR
  conf: Introduce virStoragePoolObjSourceMatchTypeISCSI
  conf: Introduce virStoragePoolObjSourceMatchTypeDEVICE
  conf: Check for storage conflicts across pool types

 src/conf/virstorageobj.c | 241 +++++++++++++++++++++++++++--------------------
 1 file changed, 140 insertions(+), 101 deletions(-)

-- 
2.9.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/4] Allow some cross pool type source device path checks

Posted by John Ferlan 7 years ago

ping?

Tks -

John

On 04/05/2017 10:45 AM, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1233129
> 
> Refactor the virStoragePoolSourceFindDuplicateDevices code a bit to
> make it a bit easier to read, then allow pool def type's that use a
> pool source device to define the source device to perform cross pool
> source device conflicts.
> 
> John Ferlan (4):
>   conf: Introduce virStoragePoolObjSourceMatchTypeDIR
>   conf: Introduce virStoragePoolObjSourceMatchTypeISCSI
>   conf: Introduce virStoragePoolObjSourceMatchTypeDEVICE
>   conf: Check for storage conflicts across pool types
> 
>  src/conf/virstorageobj.c | 241 +++++++++++++++++++++++++++--------------------
>  1 file changed, 140 insertions(+), 101 deletions(-)
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/4] Allow some cross pool type source device path checks

Posted by Michal Privoznik 7 years ago

On 04/05/2017 04:45 PM, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1233129
>
> Refactor the virStoragePoolSourceFindDuplicateDevices code a bit to
> make it a bit easier to read, then allow pool def type's that use a
> pool source device to define the source device to perform cross pool
> source device conflicts.
>
> John Ferlan (4):
>   conf: Introduce virStoragePoolObjSourceMatchTypeDIR
>   conf: Introduce virStoragePoolObjSourceMatchTypeISCSI
>   conf: Introduce virStoragePoolObjSourceMatchTypeDEVICE
>   conf: Check for storage conflicts across pool types
>
>  src/conf/virstorageobj.c | 241 +++++++++++++++++++++++++++--------------------
>  1 file changed, 140 insertions(+), 101 deletions(-)
>

ACK series.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list