[libvirt] [PATCH v2 00/11] Fix saving/setting/restoring SR-IOV VF MAC address

Laine Stump posted 11 patches 7 years, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20170324050235.29110-1-laine@laine.org
src/libvirt_private.syms    |   7 +-
src/util/virhostdev.c       | 147 ++++++--
src/util/virnetdev.c        | 855 +++++++++++++++++++++++++++++++-------------
src/util/virnetdev.h        |  29 +-
src/util/virnetdevmacvlan.c |  40 ++-
5 files changed, 778 insertions(+), 300 deletions(-)
[libvirt] [PATCH v2 00/11] Fix saving/setting/restoring SR-IOV VF MAC address
Posted by Laine Stump 7 years, 1 month ago
I pushed the 1st 10 patches of this series. The rest of the series was
ACKed as well, except patch 11, which is patch 01/11 in this repost.

Michal had asked that the rewrite of the saving/restoring of MAC and
vlan tag data use a more sane format for the data file (it has been
just an unformatted plaintext file since the beginning, which has
always bothered me, but not enough to change it.) The resulting JSON
format file is *much* nicer, and will be easier to expand if we ever
need to.

Patches 2 - 11 were already ACKed and haven't been modified, but feel
free to go over them again if you want :-)

Laine Stump (11):
  util: new functions virNetDev(Save|Read|Set)NetConfig()
  util: use new virNetDev*NetConfig() functions for macvtap
    setup/teardown
  util: use new virNetDev*NetConfig() functions for hostdev
    setup/teardown
  util: replace virHostdevNetConfigReplace with ...(Save|Set)NetConfig()
  util: save hostdev network device config before unbinding from host
    driver
  util: after hostdev assignment, restore VF MAC address via setting
    admin MAC
  util: remove unused functions from virnetdev.c
  util: if setting admin MAC to 00:00:00:00:00:00 fails, try
    02:00:00:00:00:00
  util: try *really* hard to set the MAC address of an SRIOV VF
  util: log all setting of MAC addresses and vlan tags
  util: rename virHostdevNetConfigRestore() to
    virHostdevRestoreNetConfig()

 src/libvirt_private.syms    |   7 +-
 src/util/virhostdev.c       | 147 ++++++--
 src/util/virnetdev.c        | 855 +++++++++++++++++++++++++++++++-------------
 src/util/virnetdev.h        |  29 +-
 src/util/virnetdevmacvlan.c |  40 ++-
 5 files changed, 778 insertions(+), 300 deletions(-)

-- 
2.9.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 00/11] Fix saving/setting/restoring SR-IOV VF MAC address
Posted by Michal Privoznik 7 years ago
On 24.03.2017 06:02, Laine Stump wrote:
> I pushed the 1st 10 patches of this series. The rest of the series was
> ACKed as well, except patch 11, which is patch 01/11 in this repost.
>
> Michal had asked that the rewrite of the saving/restoring of MAC and
> vlan tag data use a more sane format for the data file (it has been
> just an unformatted plaintext file since the beginning, which has
> always bothered me, but not enough to change it.) The resulting JSON
> format file is *much* nicer, and will be easier to expand if we ever
> need to.
>
> Patches 2 - 11 were already ACKed and haven't been modified, but feel
> free to go over them again if you want :-)
>
> Laine Stump (11):
>   util: new functions virNetDev(Save|Read|Set)NetConfig()
>   util: use new virNetDev*NetConfig() functions for macvtap
>     setup/teardown
>   util: use new virNetDev*NetConfig() functions for hostdev
>     setup/teardown
>   util: replace virHostdevNetConfigReplace with ...(Save|Set)NetConfig()
>   util: save hostdev network device config before unbinding from host
>     driver
>   util: after hostdev assignment, restore VF MAC address via setting
>     admin MAC
>   util: remove unused functions from virnetdev.c
>   util: if setting admin MAC to 00:00:00:00:00:00 fails, try
>     02:00:00:00:00:00
>   util: try *really* hard to set the MAC address of an SRIOV VF
>   util: log all setting of MAC addresses and vlan tags
>   util: rename virHostdevNetConfigRestore() to
>     virHostdevRestoreNetConfig()
>
>  src/libvirt_private.syms    |   7 +-
>  src/util/virhostdev.c       | 147 ++++++--
>  src/util/virnetdev.c        | 855 +++++++++++++++++++++++++++++++-------------
>  src/util/virnetdev.h        |  29 +-
>  src/util/virnetdevmacvlan.c |  40 ++-
>  5 files changed, 778 insertions(+), 300 deletions(-)
>

ACK series

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list