Resolve Coverity and build issues

[libvirt] [PATCH 05/22] conf: Remove NONNULL(1) for virDomainNumaGetNodeCount

Posted by John Ferlan 8 years, 10 months ago

Since the code checks and handles a NULL 'numa' parameter, remove the NONNULL
from the prototype.

Signed-off-by: John Ferlan <jferlan@redhat.com>
---
 src/conf/numa_conf.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/conf/numa_conf.h b/src/conf/numa_conf.h
index 05529ba..b6a5354 100644
--- a/src/conf/numa_conf.h
+++ b/src/conf/numa_conf.h
@@ -85,8 +85,8 @@ int virDomainNumatuneMaybeGetNodeset(virDomainNumaPtr numatune,
                                      virBitmapPtr *retNodeset,
                                      int cellid);
 
-size_t virDomainNumaGetNodeCount(virDomainNumaPtr numa)
-    ATTRIBUTE_NONNULL(1);
+size_t virDomainNumaGetNodeCount(virDomainNumaPtr numa);
+
 virBitmapPtr virDomainNumaGetNodeCpumask(virDomainNumaPtr numa,
                                          size_t node)
     ATTRIBUTE_NONNULL(1);
-- 
2.9.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 05/22] conf: Remove NONNULL(1) for virDomainNumaGetNodeCount

Posted by Peter Krempa 8 years, 10 months ago

On Wed, Mar 22, 2017 at 10:21:18 -0400, John Ferlan wrote:
> Since the code checks and handles a NULL 'numa' parameter, remove the NONNULL
> from the prototype.
> 
> Signed-off-by: John Ferlan <jferlan@redhat.com>
> ---
>  src/conf/numa_conf.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

ACK
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list