[libvirt] [PATCH 0/4] Split out storage object into its own module

John Ferlan posted 4 patches 7 years, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20170307213557.10424-1-jferlan@redhat.com
po/POTFILES.in                |   1 +
src/Makefile.am               |   3 +-
src/conf/storage_conf.c       | 965 ++---------------------------------------
src/conf/storage_conf.h       | 174 ++------
src/conf/virstorageobj.c      | 986 ++++++++++++++++++++++++++++++++++++++++++
src/conf/virstorageobj.h      | 156 +++++++
src/libvirt_private.syms      |  34 +-
src/storage/storage_backend.h |   2 +-
src/storage/storage_driver.c  |  24 +-
src/storage/storage_driver.h  |   2 +-
src/storage/storage_util.h    |   1 -
src/test/test_driver.c        |   1 +
12 files changed, 1255 insertions(+), 1094 deletions(-)
create mode 100644 src/conf/virstorageobj.c
create mode 100644 src/conf/virstorageobj.h
[libvirt] [PATCH 0/4] Split out storage object into its own module
Posted by John Ferlan 7 years, 1 month ago
Continuing down the pile of drivers from my RFC for making a common pool
object - we're now at storage...  For reference see patch 3 of:

http://www.redhat.com/archives/libvir-list/2017-February/msg00519.html

This series works through the storage conf adjustments. This pile is
fairly straightforward.  The virStorageVol* API's make it a bit more
interesting, but like other series we split out anything referencing
virStoragePoolObj and go from there.

John Ferlan (4):
  conf: Introduce virstorageobj
  conf: Adjust coding style for storage conf sources
  conf: Alter coding style of storage conf function prototypes
  conf: Use consistent function name prefixes for virstorageobj

 po/POTFILES.in                |   1 +
 src/Makefile.am               |   3 +-
 src/conf/storage_conf.c       | 965 ++---------------------------------------
 src/conf/storage_conf.h       | 174 ++------
 src/conf/virstorageobj.c      | 986 ++++++++++++++++++++++++++++++++++++++++++
 src/conf/virstorageobj.h      | 156 +++++++
 src/libvirt_private.syms      |  34 +-
 src/storage/storage_backend.h |   2 +-
 src/storage/storage_driver.c  |  24 +-
 src/storage/storage_driver.h  |   2 +-
 src/storage/storage_util.h    |   1 -
 src/test/test_driver.c        |   1 +
 12 files changed, 1255 insertions(+), 1094 deletions(-)
 create mode 100644 src/conf/virstorageobj.c
 create mode 100644 src/conf/virstorageobj.h

-- 
2.9.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/4] Split out storage object into its own module
Posted by Michal Privoznik 7 years, 1 month ago
On 03/07/2017 10:35 PM, John Ferlan wrote:
> Continuing down the pile of drivers from my RFC for making a common pool
> object - we're now at storage...  For reference see patch 3 of:
>
> http://www.redhat.com/archives/libvir-list/2017-February/msg00519.html
>
> This series works through the storage conf adjustments. This pile is
> fairly straightforward.  The virStorageVol* API's make it a bit more
> interesting, but like other series we split out anything referencing
> virStoragePoolObj and go from there.
>
> John Ferlan (4):
>   conf: Introduce virstorageobj
>   conf: Adjust coding style for storage conf sources
>   conf: Alter coding style of storage conf function prototypes
>   conf: Use consistent function name prefixes for virstorageobj
>
>  po/POTFILES.in                |   1 +
>  src/Makefile.am               |   3 +-
>  src/conf/storage_conf.c       | 965 ++---------------------------------------
>  src/conf/storage_conf.h       | 174 ++------
>  src/conf/virstorageobj.c      | 986 ++++++++++++++++++++++++++++++++++++++++++
>  src/conf/virstorageobj.h      | 156 +++++++
>  src/libvirt_private.syms      |  34 +-
>  src/storage/storage_backend.h |   2 +-
>  src/storage/storage_driver.c  |  24 +-
>  src/storage/storage_driver.h  |   2 +-
>  src/storage/storage_util.h    |   1 -
>  src/test/test_driver.c        |   1 +
>  12 files changed, 1255 insertions(+), 1094 deletions(-)
>  create mode 100644 src/conf/virstorageobj.c
>  create mode 100644 src/conf/virstorageobj.h
>

Sorry, but these patches do not apply cleanly anymore. Should have 
reviewed later. Can you please rebase & resend?

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/4] Split out storage object into its own module
Posted by John Ferlan 7 years, 1 month ago
[...]

> 
> Sorry, but these patches do not apply cleanly anymore. Should have
> reviewed later. Can you please rebase & resend?
> 
> Michal


I already had done so:

http://www.redhat.com/archives/libvir-list/2017-March/msg00749.html

Just forgot to update this...

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list