[Qemu-devel] [PATCH v3 0/3] target-i386: Implement query-cpu-model-expansion

Eduardo Habkost posted 3 patches 4 years, 2 months ago
Only 1 patches received!
target/i386/cpu-qom.h |   2 +
monitor.c             |   4 +-
target/i386/cpu.c     | 239 +++++++++++++++++++++++++++++++++++++++++++++++++-
3 files changed, 243 insertions(+), 2 deletions(-)

[Qemu-devel] [PATCH v3 0/3] target-i386: Implement query-cpu-model-expansion

Posted by Eduardo Habkost 4 years, 2 months ago
This series implements query-cpu-model-expansion on target-i386.

Changes v2 -> v3:
-----------------

* Rebased on top of my x86-next branch:
  https://github.com/ehabkost/qemu x86-next
* Added new patch that will extend type=full expansion to
  return every (writeable) QOM property from the CPU object

Git branch for testing:
  https://github.com/ehabkost/qemu-hacks work/x86-query-cpu-expansion

libvirt code to use the new feature already exist, and were
submitted to libvir-list, at:
  https://www.mail-archive.com/libvir-list@redhat.com/msg142168.html

Changes v1 -> v2:
-----------------

This version is highly simplified compared to v1. It contains
only an implementation that will return a limited set of
properties. I have a follow-up series that will expend type=full
expansion to return every single QOM property [note: this is now
implemented in v3], but this version will return the same data
for type=static and type=full expansion for simplicity (except
that type=static expansion will use the "base" CPU model as
base).

This means this version also won't include "pmu" and
"host-cache-info" in full expansion, and won't require special
code for those properties.

The unit test code was also removed in this version, to keep the
series simple and easier to review. Most of the patches on the
previous series were changes just to make the test case work. I
will send the test-case-related changes as a follow-up series.

---
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: libvir-list@redhat.com
Cc: Jiri Denemark <jdenemar@redhat.com>
Cc: "Jason J. Herne" <jjherne@linux.vnet.ibm.com>
Cc: Markus Armbruster <armbru@redhat.com>
Cc: Richard Henderson <rth@twiddle.net>
Cc: Igor Mammedov <imammedo@redhat.com>
Cc: Eric Blake <eblake@redhat.com>

Eduardo Habkost (3):
  target-i386: Define static "base" CPU model
  target-i386: Implement query-cpu-model-expansion QMP command
  i386: Improve query-cpu-model-expansion full mode

 target/i386/cpu-qom.h |   2 +
 monitor.c             |   4 +-
 target/i386/cpu.c     | 239 +++++++++++++++++++++++++++++++++++++++++++++++++-
 3 files changed, 243 insertions(+), 2 deletions(-)

-- 
2.11.0.259.g40922b1


Re: [libvirt] [PATCH v3 0/3] target-i386: Implement query-cpu-model-expansion

Posted by Eduardo Habkost 4 years, 2 months ago
On Wed, Feb 22, 2017 at 04:00:26PM -0300, Eduardo Habkost wrote:
> This series implements query-cpu-model-expansion on target-i386.
> 
> Changes v2 -> v3:
> -----------------
> 
> * Rebased on top of my x86-next branch:
>   https://github.com/ehabkost/qemu x86-next
> * Added new patch that will extend type=full expansion to
>   return every (writeable) QOM property from the CPU object
> 
> Git branch for testing:
>   https://github.com/ehabkost/qemu-hacks work/x86-query-cpu-expansion
> 
> libvirt code to use the new feature already exist, and were
> submitted to libvir-list, at:
>   https://www.mail-archive.com/libvir-list@redhat.com/msg142168.html
> 

As v2 was sitting on the list since Jan 16, I plan to include
this on my next pull request before soft freeze if there are no
objections.

-- 
Eduardo

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list