[libvirt] [PATCH] Revert "news: fix spelling of tunneled"

Jim Fehlig posted 1 patch 4 years, 2 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20170216025340.17045-1-jfehlig@suse.com
docs/news.xml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

[libvirt] [PATCH] Revert "news: fix spelling of tunneled"

Posted by Jim Fehlig 4 years, 2 months ago
Use of 'tunnelled' is over 100x that of 'tunneled' throughout the
code. Also, the commit providing this news item used 'tunnelled'.

This reverts commit b5ac475f506cd13adab773cebd125a45d3f2ba8d.

Signed-off-by: Jim Fehlig <jfehlig@suse.com>
---

Heh, so much for the trivial rule. I'll wait for an ACK on this one.

Sorry for the chatter...

 docs/news.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/docs/news.xml b/docs/news.xml
index 5bca75ea1..b0629b523 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -55,10 +55,10 @@
       </change>
       <change>
         <summary>
-          libxl: add tunneled migration support
+          libxl: add tunnelled migration support
         </summary>
         <description>
-          Add tunneled migration to libxl driver, which is always capable of
+          Add tunnelled migration to libxl driver, which is always capable of
           strong encryption and doesn't require any extra network connection
           other than what's required for remote access of libvirtd.
         </description>
-- 
2.11.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Revert "news: fix spelling of tunneled"

Posted by Erik Skultety 4 years, 2 months ago
On Wed, Feb 15, 2017 at 07:53:40PM -0700, Jim Fehlig wrote:
> Use of 'tunnelled' is over 100x that of 'tunneled' throughout the
> code. Also, the commit providing this news item used 'tunnelled'.
> 

I don't think it matters at all, both should be grammatically correct, it's just
a matter of convention, the former is BrE and while the latter is AmE.

So, you've got an ACK since it's correct, but it's your call whether you
really want to pollute the logs with fixing different correct spellings of a
word in the news file. :)

Erik

> This reverts commit b5ac475f506cd13adab773cebd125a45d3f2ba8d.
> 
> Signed-off-by: Jim Fehlig <jfehlig@suse.com>
> ---
> 
> Heh, so much for the trivial rule. I'll wait for an ACK on this one.
> 
> Sorry for the chatter...
> 
>  docs/news.xml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/news.xml b/docs/news.xml
> index 5bca75ea1..b0629b523 100644
> --- a/docs/news.xml
> +++ b/docs/news.xml
> @@ -55,10 +55,10 @@
>        </change>
>        <change>
>          <summary>
> -          libxl: add tunneled migration support
> +          libxl: add tunnelled migration support
>          </summary>
>          <description>
> -          Add tunneled migration to libxl driver, which is always capable of
> +          Add tunnelled migration to libxl driver, which is always capable of
>            strong encryption and doesn't require any extra network connection
>            other than what's required for remote access of libvirtd.
>          </description>
> -- 
> 2.11.0
> 
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Revert "news: fix spelling of tunneled"

Posted by Jim Fehlig 4 years, 2 months ago
On 02/16/2017 01:46 AM, Erik Skultety wrote:
> On Wed, Feb 15, 2017 at 07:53:40PM -0700, Jim Fehlig wrote:
>> Use of 'tunnelled' is over 100x that of 'tunneled' throughout the
>> code. Also, the commit providing this news item used 'tunnelled'.
>>
>
> I don't think it matters at all, both should be grammatically correct, it's just
> a matter of convention, the former is BrE and while the latter is AmE.
>
> So, you've got an ACK since it's correct, but it's your call whether you
> really want to pollute the logs with fixing different correct spellings of a
> word in the news file. :)

I don't. Nor do I want to waste anymore of peoples' time :-).

Regards,
Jim

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list