[libvirt] [PATCH v2] docs: mention bhyve SATA address changes in news.xml

Roman Bogorodskiy posted 1 patch 7 years, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20170206174919.8940-1-bogorodskiy@gmail.com
docs/news.xml | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
[libvirt] [PATCH v2] docs: mention bhyve SATA address changes in news.xml
Posted by Roman Bogorodskiy 7 years, 1 month ago
---
 docs/news.xml | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/docs/news.xml b/docs/news.xml
index f408293a1..7990cc6d4 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -56,6 +56,25 @@
           a fabric name has been removed by making it optional.
         </description>
       </change>
+      <change>
+        <summary>
+          bhyve: change address allocation schema for SATA disks
+        </summary>
+        <description>
+          Previously, the bhyve driver assigned PCI addresses to SATA disks
+          directly rather than assigning that to a controller and
+          using SATA addresses for disks. It was implemented this way
+          because bhyve has no notion of an explicit SATA controller.
+          However, as this doesn't match libvirt's understanding of
+          disk addresses, it was changed for the bhyve driver
+          to follow the common schema and have PCI addresses
+          for SATA controllers and SATA addresses for disks. If you're
+          having issues because of this, it's recommended to edit
+          the domain's XML and remove &lt;address type='pci'&gt;
+          from the &lt;disk&gt; elements with &lt;target bus='sata'/&gt;
+          and let libvirt regenerate it properly.
+        </description>
+      </change>
     </section>
   </release>
   <release version="v3.0.0" date="2017-01-17">
-- 
2.11.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2] docs: mention bhyve SATA address changes in news.xml
Posted by Andrea Bolognani 7 years, 1 month ago
On Mon, 2017-02-06 at 21:49 +0400, Roman Bogorodskiy wrote:
[...]
> +          However, as this doesn't match libvirt's understanding of
> +          disk addresses, it was changed for the bhyve driver

  "it was changed for the bhyve driver"
  → "the bhyve driver was changed"

Sorry for not catching it the first time around :/

ACK with that fixed.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2] docs: mention bhyve SATA address changes in news.xml
Posted by Roman Bogorodskiy 7 years, 1 month ago
  Andrea Bolognani wrote:

> On Mon, 2017-02-06 at 21:49 +0400, Roman Bogorodskiy wrote:
> [...]
> > +          However, as this doesn't match libvirt's understanding of
> > +          disk addresses, it was changed for the bhyve driver
> 
>   "it was changed for the bhyve driver"
>   → "the bhyve driver was changed"
> 
> Sorry for not catching it the first time around :/
> 
> ACK with that fixed.

Thanks, I've included this change as well.

I'm not sure if it's better to push it right now or wait for
https://www.redhat.com/archives/libvir-list/2017-February/msg00012.html
to get reviewed, because the bhyve driver as it is now is not completely
fixed (the patch I mentioned fixes virtio devices), so if it happens
that this patch won't get into the upcoming release, it'd be at least a
little less awkward not to claim everything's fixed...

Roman Bogorodskiy
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2] docs: mention bhyve SATA address changes in news.xml
Posted by Roman Bogorodskiy 7 years, 1 month ago
  Andrea Bolognani wrote:

> On Mon, 2017-02-06 at 21:49 +0400, Roman Bogorodskiy wrote:
> [...]
> > +          However, as this doesn't match libvirt's understanding of
> > +          disk addresses, it was changed for the bhyve driver
> 
>   "it was changed for the bhyve driver"
>   → "the bhyve driver was changed"
> 
> Sorry for not catching it the first time around :/
> 
> ACK with that fixed.

Pushed with this fix included, thanks!

Roman Bogorodskiy
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list