[PATCH] NEWS: Mention removal of compile time helper program lookup, virito-net ABI check and FDC capabilities

Peter Krempa via Devel posted 1 patch 3 months, 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/1b6fb95609f0ba3a6d1c65f25450caa4b5c4c5ec.1748521600.git.pkrempa@redhat.com
There is a newer version of this series
NEWS.rst | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
[PATCH] NEWS: Mention removal of compile time helper program lookup, virito-net ABI check and FDC capabilities
Posted by Peter Krempa via Devel 3 months, 1 week ago
From: Peter Krempa <pkrempa@redhat.com>

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 NEWS.rst | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/NEWS.rst b/NEWS.rst
index fd577021b3..884fcad2d8 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -35,6 +35,24 @@ v11.4.0 (unreleased)
         <nvram/>
       </os>

+  * All helper programs are now detected from ``$PATH`` during runtime
+
+    All of the code was now converted to dynamically look up helper programs
+    in ``$PATH`` rather than doing the lookup at build time and then compiling
+    in the result.
+
+    Programs ``mount``, ``umount``, ``mkfs``, ``modprobe``, ``rmmod``,
+    ``numad``, ``dmidecode``, ``ip``, ``tc``, ``mdevctl``, ``mm-ctl``,
+    ``iscsiadm``, ``ovs-vsctl``, ``pkttyagent``, ``bhyveload``, ``bhyvectl``,
+    ``bhyve``, ``ifconfig``, ``vzlist``, ``vzctl``, ``vzmigrate``, and the
+    tools from the lvm suite (``vgchange``, ``lvcreate``, etc..) are now not
+    needed during build and will still work properly if placed in ``$PATH``.
+
+  * qemu: Improve accuracy of FDC/floppy device support statement in capabilities XML
+
+    The data is now based on the presence of the controller in qemu rather than
+    just a denylist of machine types where floppies not work.
+
 * **Bug fixes**

   * qemu: Fix failure when reverting to internal snapshots
@@ -52,6 +70,13 @@ v11.4.0 (unreleased)
     destination host to crash when trying to resume failed post-copy
     migration.

+  * qemu: Treat the ``queues`` configuration of ``virtio-net`` as guest ABI
+
+    The queue count itself isn't a device frontend property but libvirt uses
+    it to calculate ``vectors`` option of the device which is a guest OS visible
+    property, thus ``queues`` must not change during migration. The ABI stability
+    check now handles this properly.
+

 v11.3.0 (2025-05-02)
 ====================
-- 
2.49.0
Re: [PATCH] NEWS: Mention removal of compile time helper program lookup, virito-net ABI check and FDC capabilities
Posted by Ján Tomko via Devel 3 months, 1 week ago
On a Thursday in 2025, Peter Krempa via Devel wrote:
>From: Peter Krempa <pkrempa@redhat.com>
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> NEWS.rst | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
>diff --git a/NEWS.rst b/NEWS.rst
>index fd577021b3..884fcad2d8 100644
>--- a/NEWS.rst
>+++ b/NEWS.rst
>@@ -35,6 +35,24 @@ v11.4.0 (unreleased)
>         <nvram/>
>       </os>
>
>+  * All helper programs are now detected from ``$PATH`` during runtime
>+
>+    All of the code was now converted to dynamically look up helper programs
>+    in ``$PATH`` rather than doing the lookup at build time and then compiling
>+    in the result.
>+
>+    Programs ``mount``, ``umount``, ``mkfs``, ``modprobe``, ``rmmod``,
>+    ``numad``, ``dmidecode``, ``ip``, ``tc``, ``mdevctl``, ``mm-ctl``,
>+    ``iscsiadm``, ``ovs-vsctl``, ``pkttyagent``, ``bhyveload``, ``bhyvectl``,
>+    ``bhyve``, ``ifconfig``, ``vzlist``, ``vzctl``, ``vzmigrate``, and the
>+    tools from the lvm suite (``vgchange``, ``lvcreate``, etc..) are now not
>+    needed during build and will still work properly if placed in ``$PATH``.
>+

Consider placing this into the **Packaging changes**, don't think this
is tha much interesting to end users.

>+  * qemu: Improve accuracy of FDC/floppy device support statement in capabilities XML
>+
>+    The data is now based on the presence of the controller in qemu rather than
>+    just a denylist of machine types where floppies not work.
>+
> * **Bug fixes**
>
>   * qemu: Fix failure when reverting to internal snapshots

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
Re: [PATCH] NEWS: Mention removal of compile time helper program lookup, virito-net ABI check and FDC capabilities
Posted by Peter Krempa via Devel 3 months, 1 week ago
On Thu, May 29, 2025 at 14:58:17 +0200, Ján Tomko wrote:
> On a Thursday in 2025, Peter Krempa via Devel wrote:
> > From: Peter Krempa <pkrempa@redhat.com>
> > 
> > Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> > ---
> > NEWS.rst | 25 +++++++++++++++++++++++++
> > 1 file changed, 25 insertions(+)
> > 
> > diff --git a/NEWS.rst b/NEWS.rst
> > index fd577021b3..884fcad2d8 100644
> > --- a/NEWS.rst
> > +++ b/NEWS.rst
> > @@ -35,6 +35,24 @@ v11.4.0 (unreleased)
> >         <nvram/>
> >       </os>
> > 
> > +  * All helper programs are now detected from ``$PATH`` during runtime
> > +
> > +    All of the code was now converted to dynamically look up helper programs
> > +    in ``$PATH`` rather than doing the lookup at build time and then compiling
> > +    in the result.
> > +
> > +    Programs ``mount``, ``umount``, ``mkfs``, ``modprobe``, ``rmmod``,
> > +    ``numad``, ``dmidecode``, ``ip``, ``tc``, ``mdevctl``, ``mm-ctl``,
> > +    ``iscsiadm``, ``ovs-vsctl``, ``pkttyagent``, ``bhyveload``, ``bhyvectl``,
> > +    ``bhyve``, ``ifconfig``, ``vzlist``, ``vzctl``, ``vzmigrate``, and the
> > +    tools from the lvm suite (``vgchange``, ``lvcreate``, etc..) are now not
> > +    needed during build and will still work properly if placed in ``$PATH``.
> > +
> 
> Consider placing this into the **Packaging changes**, don't think this
> is tha much interesting to end users.

Hmm, you're probably right. The thing is though that these changes were
done because distros (fedora in this case) did some shenanigans with
moving /sbin/ into /bin/ but differently based on if you upgraded or
installed freshly, which actually broke some stuff for users as paths
were compiled in.

That fact isn't obvious from what I wrote if you don't know the
backstory.

Any suggestions?

> 
> > +  * qemu: Improve accuracy of FDC/floppy device support statement in capabilities XML
> > +
> > +    The data is now based on the presence of the controller in qemu rather than
> > +    just a denylist of machine types where floppies not work.
> > +
> > * **Bug fixes**
> > 
> >   * qemu: Fix failure when reverting to internal snapshots
> 
> Reviewed-by: Ján Tomko <jtomko@redhat.com>
> 
> Jano