[PATCH v2 1/2] qemu: support append param on live attaching file chardev

Nikolay Shirokovskiy posted 2 patches 5 years, 2 months ago
[PATCH v2 1/2] qemu: support append param on live attaching file chardev
Posted by Nikolay Shirokovskiy 5 years, 2 months ago
Currently it is simply ignored.

Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
---
 src/qemu/qemu_monitor_json.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
index 47ee1ff..ff03a5a 100644
--- a/src/qemu/qemu_monitor_json.c
+++ b/src/qemu/qemu_monitor_json.c
@@ -7497,6 +7497,10 @@ qemuMonitorJSONAttachCharDevCommand(const char *chrID,
         backend_type = "file";
         if (virJSONValueObjectAppendString(data, "out", chr->data.file.path) < 0)
             goto cleanup;
+        if (virJSONValueObjectAdd(data,
+                                  "T:append", chr->data.file.append,
+                                  NULL) < 0)
+            goto cleanup;
         break;
 
     case VIR_DOMAIN_CHR_TYPE_DEV:
-- 
1.8.3.1

Re: [PATCH v2 1/2] qemu: support append param on live attaching file chardev
Posted by Daniel Henrique Barboza 5 years, 2 months ago

On 12/2/20 9:25 AM, Nikolay Shirokovskiy wrote:
> Currently it is simply ignored.
> 
> Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
> ---

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>

>   src/qemu/qemu_monitor_json.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
> index 47ee1ff..ff03a5a 100644
> --- a/src/qemu/qemu_monitor_json.c
> +++ b/src/qemu/qemu_monitor_json.c
> @@ -7497,6 +7497,10 @@ qemuMonitorJSONAttachCharDevCommand(const char *chrID,
>           backend_type = "file";
>           if (virJSONValueObjectAppendString(data, "out", chr->data.file.path) < 0)
>               goto cleanup;
> +        if (virJSONValueObjectAdd(data,
> +                                  "T:append", chr->data.file.append,
> +                                  NULL) < 0)
> +            goto cleanup;
>           break;
>   
>       case VIR_DOMAIN_CHR_TYPE_DEV:
>