[v1] add phytium FT-2000+ and Tengyun-S2500 support on arm architecture.

[PATCH] add phytium FT-2000+ and Tengyun-S2500 support on arm architecture.

yangshaojun19@163.com posted 1 patch 3 years, 5 months ago

Diff against v1 v1
Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/1605603750-18979-1-git-send-email-yangshaojun19@163.com

There is a newer version of this series

src/cpu_map/arm_Phytium.xml | 10 ++++++++++
src/cpu_map/arm_vendors.xml |  1 +
src/cpu_map/index.xml       |  3 +++
3 files changed, 14 insertions(+)
create mode 100644 src/cpu_map/arm_Phytium.xml

Expand all Fold all

[PATCH] add phytium FT-2000+ and Tengyun-S2500 support on arm architecture.

Posted by yangshaojun19@163.com 3 years, 5 months ago

From: yangshaojun <yangshaojun@phytium.com.cn>

Signed-off-by: yangshaojun <yangshaojun@phytium.com.cn>
---
 src/cpu_map/arm_Phytium.xml | 10 ++++++++++
 src/cpu_map/arm_vendors.xml |  1 +
 src/cpu_map/index.xml       |  3 +++
 3 files changed, 14 insertions(+)
 create mode 100644 src/cpu_map/arm_Phytium.xml

diff --git a/src/cpu_map/arm_Phytium.xml b/src/cpu_map/arm_Phytium.xml
new file mode 100644
index 0000000..f8b4852
--- /dev/null
+++ b/src/cpu_map/arm_Phytium.xml
@@ -0,0 +1,10 @@
+<cpus>
+  <model name='FT-2000+'>
+    <vendor name='Phytium'/>
+    <pvr value='0x662'/>
+  </model>
+  <model name='Tengyun-S2500'>
+    <vendor name='Phytium'/>
+    <pvr value='0x663'/>
+  </model>
+</cpus>
diff --git a/src/cpu_map/arm_vendors.xml b/src/cpu_map/arm_vendors.xml
index ff799ef..4465463 100644
--- a/src/cpu_map/arm_vendors.xml
+++ b/src/cpu_map/arm_vendors.xml
@@ -11,4 +11,5 @@
   <vendor name='Qualcomm' value='0x51'/>
   <vendor name='Marvell' value='0x56'/>
   <vendor name='Intel' value='0x69'/>
+  <vendor name='Phytium' value='0x70'/>
 </cpus>
diff --git a/src/cpu_map/index.xml b/src/cpu_map/index.xml
index 08f052e..e2c454b 100644
--- a/src/cpu_map/index.xml
+++ b/src/cpu_map/index.xml
@@ -103,5 +103,8 @@
 
     <!-- Hisilicon-based CPU models -->
     <include filename='arm_Kunpeng-920.xml'/>
+
+    <!-- Phytium-based CPU models -->
+    <include filename='arm_Phytium.xml'/>
   </arch>
 </cpus>
-- 
2.7.4

Re: [PATCH] add phytium FT-2000+ and Tengyun-S2500 support on arm architecture.

Posted by Andrea Bolognani 3 years, 5 months ago

On Tue, 2020-11-17 at 17:02 +0800, yangshaojun19@163.com wrote:
> From: yangshaojun <yangshaojun@phytium.com.cn>
> 
> Signed-off-by: yangshaojun <yangshaojun@phytium.com.cn>

Both the git authorship information and the Signed-off-by tag should
contain information in the form

  FirstName LastName <email@address>

Please update them.

> +++ b/src/cpu_map/arm_Phytium.xml
> @@ -0,0 +1,10 @@
> +<cpus>
> +  <model name='FT-2000+'>
> +    <vendor name='Phytium'/>
> +    <pvr value='0x662'/>
> +  </model>
> +  <model name='Tengyun-S2500'>
> +    <vendor name='Phytium'/>
> +    <pvr value='0x663'/>
> +  </model>
> +</cpus>

Looking at how other CPU models are handled, there's usually a single
CPU model per XML file, so this should probably be

  # src/cpu_map/arm_FT-2000plus.xml
  <cpus>
    <model name='FT-2000+'>
      <vendor name='Phytium'/>
      <pvr value='0x662'/>
    </model>
  <cpus>

  # src/cpu_map/arm_Tengyun-S2500.xml
  <cpus>
    <model name='Tengyun-S2500'>
      <vendor name='Phytium'/>
      <pvr value='0x663'/>
    </model>
  <cpus>

with both files being included by src/cpu_map/index.xml of course.

More importantly, you need to list these files in the cpumap_data
list defined in src/cpu_map/meson.build, or they will not be
installed on the target system.

Sorry for not pointing up these issues the first time around.
Everything else looks good.

-- 
Andrea Bolognani / Red Hat / Virtualization