[PATCH v2 3/3] downscript: docs: add docs and news

Chen Hanxiao posted 3 patches 5 years, 8 months ago
[PATCH v2 3/3] downscript: docs: add docs and news
Posted by Chen Hanxiao 5 years, 8 months ago
Signed-off-by: Chen Hanxiao <chen_han_xiao@126.com>
---
 docs/formatdomain.html.in |  6 +++++-
 docs/news.xml             | 10 ++++++++++
 2 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 23eb029234..4e2320d537 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -5879,7 +5879,10 @@
     <p>
       After creating/opening the tap device, an optional shell script
       (given in the <code>path</code> attribute of
-      the <code>&lt;script&gt;</code> element) will be run; this can
+      the <code>&lt;script&gt;</code> element) will be run;
+      Also, after detaching/closing the tap device, an optional shell
+      script (given in the <code>path</code> attribute of
+      the <code>&lt;downscript&gt;</code> element) will be run; this can
       be used to do whatever extra host network integration is
       required.
     </p>
@@ -5889,6 +5892,7 @@
 &lt;devices&gt;
   &lt;interface type='ethernet'&gt;
     &lt;script path='/etc/qemu-ifup-mynet'/&gt;
+    &lt;downscript path='/etc/qemu-ifdown-mynet'/&gt;
   &lt;/interface&gt;
   ...
   &lt;interface type='ethernet'&gt;
diff --git a/docs/news.xml b/docs/news.xml
index 4cef804aac..67fb85377d 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -52,6 +52,16 @@
   </release>
   <release version="v6.3.0" date="2020-05-05">
     <section title="New features">
+      <change>
+        <summary>
+          qemu: support network interface downscript
+        </summary>
+        <description>
+          QEMU has the ability to run a script when a NIC is brought up
+          and down. Libvirt only enables use of the up script.
+          Now add support for postscript when NIC is down/detached.
+        </description>
+      </change>
       <change>
         <summary>
           qemu: support disabling hotplug/unplug of PCIe devices
-- 
2.23.0

Re: [PATCH v2 3/3] downscript: docs: add docs and news
Posted by Peter Krempa 5 years, 8 months ago
On Mon, May 25, 2020 at 12:16:49 -0400, Chen Hanxiao wrote:
> Signed-off-by: Chen Hanxiao <chen_han_xiao@126.com>
> ---
>  docs/formatdomain.html.in |  6 +++++-
>  docs/news.xml             | 10 ++++++++++
>  2 files changed, 15 insertions(+), 1 deletion(-)
> 
> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index 23eb029234..4e2320d537 100644
> --- a/docs/formatdomain.html.in
> +++ b/docs/formatdomain.html.in

[...]

> diff --git a/docs/news.xml b/docs/news.xml
> index 4cef804aac..67fb85377d 100644
> --- a/docs/news.xml
> +++ b/docs/news.xml

Changes to 'news.xml' must be in a separate commit. This is to decrease
likelihood of conflicts when backporting patches.