[PATCH] util: virnetdevopenvswitch: Delete unused code

Yan Wang posted 1 patch 1 week ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/1589338310-24623-1-git-send-email-wangyan122@huawei.com
src/util/virnetdevopenvswitch.c | 3 ---
1 file changed, 3 deletions(-)

[PATCH] util: virnetdevopenvswitch: Delete unused code

Posted by Yan Wang 1 week ago
It was never used since commit @57b5e27d3d7 introduced it.

Signed-off-by: Yan Wang <wangyan122@huawei.com>
---
 src/util/virnetdevopenvswitch.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/util/virnetdevopenvswitch.c b/src/util/virnetdevopenvswitch.c
index f961777411..d16af72bdf 100644
--- a/src/util/virnetdevopenvswitch.c
+++ b/src/util/virnetdevopenvswitch.c
@@ -491,8 +491,6 @@ virNetDevOpenvswitchGetVhostuserIfname(const char *path,
                                        char **ifname)
 {
     char *tmpIfname = NULL;
-    char **tokens = NULL;
-    size_t ntokens = 0;
     int status;
     int ret = -1;
     g_autoptr(virCommand) cmd = NULL;
@@ -524,7 +522,6 @@ virNetDevOpenvswitchGetVhostuserIfname(const char *path,
     ret = 1;
 
  cleanup:
-    virStringListFreeCount(tokens, ntokens);
     return ret;
 }
 
-- 
2.23.0

Re: [PATCH] util: virnetdevopenvswitch: Delete unused code

Posted by Ján Tomko 1 week ago
On a Wednesday in 2020, Yan Wang wrote:
>It was never used since commit @57b5e27d3d7 introduced it.
>
>Signed-off-by: Yan Wang <wangyan122@huawei.com>
>---
> src/util/virnetdevopenvswitch.c | 3 ---
> 1 file changed, 3 deletions(-)
>
>diff --git a/src/util/virnetdevopenvswitch.c b/src/util/virnetdevopenvswitch.c

Reviewed-by: Ján Tomko <jtomko@redhat.com>

and pushed to master.

Jano