util: fix iteration in virSocketAddrResolveService

[PATCH] util: fix iteration in virSocketAddrResolveService

Nikolay Shirokovskiy posted 1 patch 4 years ago

Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/1586787511-767454-1-git-send-email-nshirokovskiy@virtuozzo.com

src/util/virsocketaddr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] util: fix iteration in virSocketAddrResolveService

Posted by Nikolay Shirokovskiy 4 years ago

getaddrinfo returns linked list. Fix iteration accordingly.

Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
---
 src/util/virsocketaddr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/util/virsocketaddr.c b/src/util/virsocketaddr.c
index 4cad329..4c9f124 100644
--- a/src/util/virsocketaddr.c
+++ b/src/util/virsocketaddr.c
@@ -271,7 +271,7 @@ int virSocketAddrResolveService(const char *service)
             port = ntohs(in.sin6_port);
             goto cleanup;
         }
-        tmp++;
+        tmp = tmp->ai_next;
     }
 
     virReportError(VIR_ERR_SYSTEM_ERROR,
-- 
1.8.3.1

Re: [PATCH] util: fix iteration in virSocketAddrResolveService

Posted by Daniel Henrique Barboza 4 years ago


On 4/13/20 11:18 AM, Nikolay Shirokovskiy wrote:
> getaddrinfo returns linked list. Fix iteration accordingly.
> 
> Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
> ---

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>


>   src/util/virsocketaddr.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/util/virsocketaddr.c b/src/util/virsocketaddr.c
> index 4cad329..4c9f124 100644
> --- a/src/util/virsocketaddr.c
> +++ b/src/util/virsocketaddr.c
> @@ -271,7 +271,7 @@ int virSocketAddrResolveService(const char *service)
>               port = ntohs(in.sin6_port);
>               goto cleanup;
>           }
> -        tmp++;
> +        tmp = tmp->ai_next;
>       }
>   
>       virReportError(VIR_ERR_SYSTEM_ERROR,
>