[PATCH] libvirt-stream.c: Use g_autofree

Seeteena Thoufeek posted 1 patch 4 years, 1 month ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/1586782166-32717-1-git-send-email-s1seetee@linux.vnet.ibm.com
src/libvirt-stream.c | 16 ++++------------
1 file changed, 4 insertions(+), 12 deletions(-)
[PATCH] libvirt-stream.c: Use g_autofree
Posted by Seeteena Thoufeek 4 years, 1 month ago
Signed-off-by: Seeteena Thoufeek <s1seetee@linux.vnet.ibm.com>
---
 src/libvirt-stream.c | 16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)

diff --git a/src/libvirt-stream.c b/src/libvirt-stream.c
index 6f6bb5d..41b9cc1 100644
--- a/src/libvirt-stream.c
+++ b/src/libvirt-stream.c
@@ -573,7 +573,7 @@ virStreamSendAll(virStreamPtr stream,
                  virStreamSourceFunc handler,
                  void *opaque)
 {
-    char *bytes = NULL;
+    g_autofree char *bytes = NULL;
     size_t want = VIR_NET_MESSAGE_LEGACY_PAYLOAD_MAX;
     int ret = -1;
     VIR_DEBUG("stream=%p, handler=%p, opaque=%p", stream, handler, opaque);
@@ -616,8 +616,6 @@ virStreamSendAll(virStreamPtr stream,
     ret = 0;
 
  cleanup:
-    VIR_FREE(bytes);
-
     if (ret != 0) {
         virErrorPtr orig_err;
 
@@ -706,7 +704,7 @@ int virStreamSparseSendAll(virStreamPtr stream,
                            virStreamSourceSkipFunc skipHandler,
                            void *opaque)
 {
-    char *bytes = NULL;
+    g_autofree char *bytes = NULL;
     size_t bufLen = VIR_NET_MESSAGE_LEGACY_PAYLOAD_MAX;
     int ret = -1;
     unsigned long long dataLen = 0;
@@ -787,8 +785,6 @@ int virStreamSparseSendAll(virStreamPtr stream,
     ret = 0;
 
  cleanup:
-    VIR_FREE(bytes);
-
     if (ret != 0) {
         virErrorPtr orig_err;
 
@@ -847,7 +843,7 @@ virStreamRecvAll(virStreamPtr stream,
                  virStreamSinkFunc handler,
                  void *opaque)
 {
-    char *bytes = NULL;
+    g_autofree char *bytes = NULL;
     size_t want = VIR_NET_MESSAGE_LEGACY_PAYLOAD_MAX;
     int ret = -1;
     VIR_DEBUG("stream=%p, handler=%p, opaque=%p", stream, handler, opaque);
@@ -892,8 +888,6 @@ virStreamRecvAll(virStreamPtr stream,
     ret = 0;
 
  cleanup:
-    VIR_FREE(bytes);
-
     if (ret != 0) {
         virErrorPtr orig_err;
 
@@ -964,7 +958,7 @@ virStreamSparseRecvAll(virStreamPtr stream,
                        virStreamSinkHoleFunc holeHandler,
                        void *opaque)
 {
-    char *bytes = NULL;
+    g_autofree char *bytes = NULL;
     size_t want = VIR_NET_MESSAGE_LEGACY_PAYLOAD_MAX;
     const unsigned int flags = VIR_STREAM_RECV_STOP_AT_HOLE;
     int ret = -1;
@@ -1025,8 +1019,6 @@ virStreamSparseRecvAll(virStreamPtr stream,
     ret = 0;
 
  cleanup:
-    VIR_FREE(bytes);
-
     if (ret != 0) {
         virErrorPtr orig_err;
 
-- 
1.8.3.1


Re: [PATCH] libvirt-stream.c: Use g_autofree
Posted by Erik Skultety 4 years, 1 month ago
On Mon, Apr 13, 2020 at 06:19:26PM +0530, Seeteena Thoufeek wrote:
> Signed-off-by: Seeteena Thoufeek <s1seetee@linux.vnet.ibm.com>
> ---
Reviewed-by: Erik Skultety <eskultet@redhat.com>