[libvirt] [PATCH] docs: rng: make newly introduced features in domcaps optional

Nikolay Shirokovskiy posted 1 patch 9 weeks ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/1552551695-771263-1-git-send-email-nshirokovskiy@virtuozzo.com
docs/schemas/domaincaps.rng | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)

[libvirt] [PATCH] docs: rng: make newly introduced features in domcaps optional

Posted by Nikolay Shirokovskiy 9 weeks ago
<features> was introduced in 24f17f55 and have only gic child element
at the time. Thus from backcompat POV the other children are optional.

Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
---
 docs/schemas/domaincaps.rng | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/docs/schemas/domaincaps.rng b/docs/schemas/domaincaps.rng
index 7d80693..2258365 100644
--- a/docs/schemas/domaincaps.rng
+++ b/docs/schemas/domaincaps.rng
@@ -183,9 +183,15 @@
     <element name='features'>
       <interleave>
         <ref name='gic'/>
-        <ref name='vmcoreinfo'/>
-        <ref name='vmgenid'/>
-        <ref name='sev'/>
+        <optional>
+          <ref name='vmcoreinfo'/>
+        </optional>
+        <optional>
+          <ref name='vmgenid'/>
+        </optional>
+        <optional>
+          <ref name='sev'/>
+        </optional>
       </interleave>
     </element>
   </define>
-- 
1.8.3.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] docs: rng: make newly introduced features in domcaps optional

Posted by John Ferlan 9 weeks ago

On 3/14/19 4:21 AM, Nikolay Shirokovskiy wrote:
> <features> was introduced in 24f17f55 and have only gic child element
> at the time. Thus from backcompat POV the other children are optional.
> 
> Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
> ---
>  docs/schemas/domaincaps.rng | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 

See patch 9 of the series

https://www.redhat.com/archives/libvir-list/2019-March/msg00374.html

John

> diff --git a/docs/schemas/domaincaps.rng b/docs/schemas/domaincaps.rng
> index 7d80693..2258365 100644
> --- a/docs/schemas/domaincaps.rng
> +++ b/docs/schemas/domaincaps.rng
> @@ -183,9 +183,15 @@
>      <element name='features'>
>        <interleave>
>          <ref name='gic'/>
> -        <ref name='vmcoreinfo'/>
> -        <ref name='vmgenid'/>
> -        <ref name='sev'/>
> +        <optional>
> +          <ref name='vmcoreinfo'/>
> +        </optional>
> +        <optional>
> +          <ref name='vmgenid'/>
> +        </optional>
> +        <optional>
> +          <ref name='sev'/>
> +        </optional>
>        </interleave>
>      </element>
>    </define>
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list