[libvirt] [PATCH 4/9] schema: snapshot: add persistent domain config

Nikolay Shirokovskiy posted 9 patches 5 years, 11 months ago
[libvirt] [PATCH 4/9] schema: snapshot: add persistent domain config
Posted by Nikolay Shirokovskiy 5 years, 11 months ago
Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
---
 docs/schemas/domainsnapshot.rng | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/docs/schemas/domainsnapshot.rng b/docs/schemas/domainsnapshot.rng
index 2680887..405e614 100644
--- a/docs/schemas/domainsnapshot.rng
+++ b/docs/schemas/domainsnapshot.rng
@@ -84,6 +84,16 @@
           </choice>
         </optional>
         <optional>
+          <element name='persistent'>
+            <!-- Nested grammar ensures that any of our overrides of
+                 storagecommon/domaincommon defines do not conflict
+                 with any domain.rng overrides.  -->
+            <grammar>
+              <include href='domain.rng'/>
+            </grammar>
+          </element>
+        </optional>
+        <optional>
           <element name='parent'>
             <element name='name'>
               <text/>
-- 
1.8.3.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 4/9] schema: snapshot: add persistent domain config
Posted by John Ferlan 5 years, 11 months ago
Maybe a few words here about the option being used to hold a persistent
config that could be different than the snapshot's running domain def.

On 12/13/18 3:03 AM, Nikolay Shirokovskiy wrote:
> Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
> ---
>  docs/schemas/domainsnapshot.rng | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 

Seems reasonable - although I wonder if this should be combined with the
next two patches as well... That's not a big deal though...

I actually prefer "persistent" over "newDef" or a/k/a "nextPersistentDef".

Reviewed-by: John Ferlan <jferlan@redhat.com>

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list