[libvirt] [PATCH 1/9] qemu: release job on cleanup path

Nikolay Shirokovskiy posted 9 patches 5 years, 11 months ago
[libvirt] [PATCH 1/9] qemu: release job on cleanup path
Posted by Nikolay Shirokovskiy 5 years, 11 months ago
Introduced-by: 6a6f6b91e qemu: "Fix CPU model broken by older libvirt"
Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
---
 src/qemu/qemu_driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 90cbc02..3242a60 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -16457,7 +16457,7 @@ qemuDomainRevertToSnapshot(virDomainSnapshotPtr snapshot,
              */
             if (cookie &&
                 qemuDomainFixupCPUs(vm, &cookie->cpu) < 0)
-                goto cleanup;
+                goto endjob;
 
             rc = qemuProcessStart(snapshot->domain->conn, driver, vm,
                                   cookie ? cookie->cpu : NULL,
-- 
1.8.3.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 1/9] qemu: release job on cleanup path
Posted by John Ferlan 5 years, 11 months ago

On 12/13/18 3:03 AM, Nikolay Shirokovskiy wrote:
> Introduced-by: 6a6f6b91e qemu: "Fix CPU model broken by older libvirt"

Add a blank line here...

> Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
> ---
>  src/qemu/qemu_driver.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: John Ferlan <jferlan@redhat.com>

John

This is separate from the "core" of this and could be pushed without
other changes.

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list