[v1] use GNU C's cleanup attribute in src/util (batch II)

[libvirt] [PATCH v1 18/40] util: hook: use VIR_AUTOPTR for aggregate types

Posted by Sukrit Bhatnagar 7 years, 6 months ago

By making use of GNU C's cleanup attribute handled by the
VIR_AUTOPTR macro for declaring aggregate pointer variables,
majority of the calls to *Free functions can be dropped, which
in turn leads to getting rid of most of our cleanup sections.

Signed-off-by: Sukrit Bhatnagar <skrtbhtngr@gmail.com>
---
 src/util/virhook.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/util/virhook.c b/src/util/virhook.c
index 51f0eb5..de80947 100644
--- a/src/util/virhook.c
+++ b/src/util/virhook.c
@@ -230,7 +230,7 @@ virHookCall(int driver,
 {
     int ret;
     VIR_AUTOFREE(char *) path = NULL;
-    virCommandPtr cmd;
+    VIR_AUTOPTR(virCommand) cmd = NULL;
     const char *drvstr;
     const char *opstr;
     const char *subopstr;
@@ -312,7 +312,5 @@ virHookCall(int driver,
                        virGetLastErrorMessage());
     }
 
-    virCommandFree(cmd);
-
     return ret;
 }
-- 
1.8.3.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v1 18/40] util: hook: use VIR_AUTOPTR for aggregate types

Posted by Erik Skultety 7 years, 6 months ago

On Sat, Jul 21, 2018 at 05:36:50PM +0530, Sukrit Bhatnagar wrote:
> By making use of GNU C's cleanup attribute handled by the
> VIR_AUTOPTR macro for declaring aggregate pointer variables,
> majority of the calls to *Free functions can be dropped, which
> in turn leads to getting rid of most of our cleanup sections.
>
> Signed-off-by: Sukrit Bhatnagar <skrtbhtngr@gmail.com>
> ---

Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list