On Wed, Jan 10, 2018 at 08:14:48PM +0800, Wu Zongyong wrote:
> Some capabilities of node devices rely on what driver they bound to,
> and therefore, these capabilities may change when the driver change.
> In current implemention, it is not consistent between real status and
> the status we get by invoking nodedev interfaces.
> So, this series of patches try to manually update devices' capabilities
> each time before nodedev driver interfaces invoked.
Hi, so I finally posted the series I mentioned in my previous reviews,
unfortunately, after applying your patches there were a lot of merge conflicts
so I had to write them from scratch, so I at least added you as an honorable
mention in patch equivalents of your patches 2 and 3. Unless someone objects to
the series as a whole, your patch 1 will be unnecessary.
Feel free to have a look at the series [1] and test whether it works as
expected (it did in my testing, both virsh and python).
Erik
[1] https://www.redhat.com/archives/libvir-list/2018-January/msg00851.html
>
> Wu Zongyong (3):
>
> v2->v3:
> 1. split a single patch to three part
> 2. fix memory leak and lock problems
> 3. update caps before invoking nodedev driver interfaces (refer to patch 3/3)
>
>
> nodedev: add macro guard to node_device_udev header file
> nodedev: update mdev_types caps before dumpxml
> nodedev: update caps before invoking nodedev driver interfaces
>
> src/node_device/node_device_driver.c | 55 +++++++++++++++++++++++++++++++
> src/node_device/node_device_linux_sysfs.c | 22 +++++++++++++
> src/node_device/node_device_udev.c | 37 +++++++++++++++++----
> src/node_device/node_device_udev.h | 18 +++++++---
> 4 files changed, 121 insertions(+), 11 deletions(-)
>
> --
> 1.9.1
>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list