[libvirt] [PATCH] Doc fix of /etc/libvirt/libvirt-guests

Lily Zhu posted 1 patch 6 years, 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/1502728776-3928-1-git-send-email-lizhu@redhat.com
tools/libvirt-guests.sysconf | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
[libvirt] [PATCH] Doc fix of /etc/libvirt/libvirt-guests
Posted by Lily Zhu 6 years, 8 months ago
As in previous doc, it may cause confusion about whether parallel_shutdown would
take effect when guests are asked to suspend on host shutdown. Hence, changed the
doc of parallel_shutdown, make it more clear.

Signed-off-by: Lily Zhu <lizhu@redhat.com>
---
 tools/libvirt-guests.sysconf | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tools/libvirt-guests.sysconf b/tools/libvirt-guests.sysconf
index 2770056..785c3c0 100644
--- a/tools/libvirt-guests.sysconf
+++ b/tools/libvirt-guests.sysconf
@@ -24,8 +24,10 @@
 #             value suitable for your guests.
 #ON_SHUTDOWN=suspend
 
-# If set to non-zero, shutdown will suspend guests concurrently. Number of
-# guests on shutdown at any time will not exceed number set in this variable.
+# Number of guests will be shutdown concurrently, taking effect when 
+# "ON_SHUTDOWN" is set to "shutdown". If Set to 0, guests will be 
+# shutdown one after another. Number of guests on shutdown at any 
+# time will not exceed number set in this variable.
 #PARALLEL_SHUTDOWN=0
 
 # Number of seconds we're willing to wait for a guest to shut down. If parallel
-- 
1.8.3.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Doc fix of /etc/libvirt/libvirt-guests
Posted by Peter Krempa 6 years, 8 months ago
On Tue, Aug 15, 2017 at 00:39:36 +0800, Lily Zhu wrote:
> As in previous doc, it may cause confusion about whether parallel_shutdown would
> take effect when guests are asked to suspend on host shutdown. Hence, changed the
> doc of parallel_shutdown, make it more clear.
> 
> Signed-off-by: Lily Zhu <lizhu@redhat.com>
> ---
>  tools/libvirt-guests.sysconf | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/libvirt-guests.sysconf b/tools/libvirt-guests.sysconf
> index 2770056..785c3c0 100644
> --- a/tools/libvirt-guests.sysconf
> +++ b/tools/libvirt-guests.sysconf
> @@ -24,8 +24,10 @@
>  #             value suitable for your guests.
>  #ON_SHUTDOWN=suspend
>  
> -# If set to non-zero, shutdown will suspend guests concurrently. Number of
> -# guests on shutdown at any time will not exceed number set in this variable.
> +# Number of guests will be shutdown concurrently, taking effect when 
> +# "ON_SHUTDOWN" is set to "shutdown". If Set to 0, guests will be 
> +# shutdown one after another. Number of guests on shutdown at any 
> +# time will not exceed number set in this variable.

All the lines contain trailing whitespace which we don't allow.

>  #PARALLEL_SHUTDOWN=0

ACK, I've fixed the broken whitespace and tweaked the commit message to
conform to our format and pushed this patch.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list