[v1] fix error in printf format string

[PATCH] fix error in printf format string

Zhenyu Ye posted 1 patch 2 years, 8 months ago

Diff against v1 v1
Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/14a5e106-7a21-b424-190f-b4528a62f921@huawei.com

There is a newer version of this series

src/libvirt-domain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] fix error in printf format string

Posted by Zhenyu Ye 2 years, 8 months ago

Use %s to print NULLSTR(duri).

Reported-by: Peng Liang <liangpeng10@huawei.com>
Signed-off-by: Zhenyu Ye <yezhenyu2@huawei.com>
---
 src/libvirt-domain.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index 4eb14d4176..3c4204e563 100644
--- a/src/libvirt-domain.c
+++ b/src/libvirt-domain.c
@@ -4215,7 +4215,7 @@ virDomainMigrateToURI(virDomainPtr domain,
     const char *dconnuri = NULL;
     const char *miguri = NULL;

-    VIR_DOMAIN_DEBUG(domain, "duri=%p, flags=0x%lx, dname=%s, bandwidth=%lu",
+    VIR_DOMAIN_DEBUG(domain, "duri=%s, flags=0x%lx, dname=%s, bandwidth=%lu",
                      NULLSTR(duri), flags, NULLSTR(dname), bandwidth);

     virResetLastError();
-- 
2.27.0

Re: [PATCH] fix error in printf format string

Posted by Michal Prívozník 2 years, 8 months ago

On 8/19/21 2:14 PM, Zhenyu Ye wrote:
> Use %s to print NULLSTR(duri).
> 
> Reported-by: Peng Liang <liangpeng10@huawei.com>
> Signed-off-by: Zhenyu Ye <yezhenyu2@huawei.com>
> ---
>  src/libvirt-domain.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
> index 4eb14d4176..3c4204e563 100644
> --- a/src/libvirt-domain.c
> +++ b/src/libvirt-domain.c
> @@ -4215,7 +4215,7 @@ virDomainMigrateToURI(virDomainPtr domain,
>      const char *dconnuri = NULL;
>      const char *miguri = NULL;
> 
> -    VIR_DOMAIN_DEBUG(domain, "duri=%p, flags=0x%lx, dname=%s, bandwidth=%lu",
> +    VIR_DOMAIN_DEBUG(domain, "duri=%s, flags=0x%lx, dname=%s, bandwidth=%lu",
>                       NULLSTR(duri), flags, NULLSTR(dname), bandwidth);
> 
>      virResetLastError();
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

and pushed.

Michal