The use of 'git send-email' is described in detail in the
contributor guidelines (docs/hacking.html), which are
mentioned in docs/contribute.html, the non-local version
of which is in turn mentioned in README.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 README.md | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/README.md b/README.md
index 6957881..510646f 100644
--- a/README.md
+++ b/README.md
@@ -64,8 +64,7 @@ Contributing
 
 The libvirt project welcomes contributions in many ways. For most components
 the best way to contribute is to send patches to the primary development
-mailing list, using the `git send-email` command. Further guidance on this
-can be found on the website:
+mailing list. Further guidance on this can be found on the website:
 
 * <https://libvirt.org/contribute.html>
 
-- 
2.7.5

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Mon, Jun 26, 2017 at 12:24:44 +0200, Andrea Bolognani wrote:
> The use of 'git send-email' is described in detail in the
> contributor guidelines (docs/hacking.html), which are
> mentioned in docs/contribute.html, the non-local version
> of which is in turn mentioned in README.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  README.md | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/README.md b/README.md
> index 6957881..510646f 100644
> --- a/README.md
> +++ b/README.md
> @@ -64,8 +64,7 @@ Contributing
>  
>  The libvirt project welcomes contributions in many ways. For most components
>  the best way to contribute is to send patches to the primary development
> -mailing list, using the `git send-email` command. Further guidance on this
> -can be found on the website:
> +mailing list. Further guidance on this can be found on the website:

I think you should not drop the hint to git send-email as users kept
sending patches as attachments.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Mon, 2017-06-26 at 13:23 +0200, Peter Krempa wrote:
> >  The libvirt project welcomes contributions in many ways. For most components
> >  the best way to contribute is to send patches to the primary development
> > -mailing list, using the `git send-email` command. Further guidance on this
> > -can be found on the website:
> > +mailing list. Further guidance on this can be found on the website:
> 
> I think you should not drop the hint to git send-email as users kept
> sending patches as attachments.

Even after patch 2/4 added a trail from contribute.html
(which was already pointed to by README a couple of lines
after mentioning git send-email) to hacking.html?

We have a lot of information about how to use and configure
git send-email in hacking.html, so I think that people who
stop at the mention in README without going further and
reading the full contributor guidelines will botch sending
the patches in some way regardless. That's why I feel like
mentioning it there is not very helpful.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Mon, Jun 26, 2017 at 14:13:09 +0200, Andrea Bolognani wrote:
> On Mon, 2017-06-26 at 13:23 +0200, Peter Krempa wrote:
> > >  The libvirt project welcomes contributions in many ways. For most components
> > >  the best way to contribute is to send patches to the primary development
> > > -mailing list, using the `git send-email` command. Further guidance on this
> > > -can be found on the website:
> > > +mailing list. Further guidance on this can be found on the website:
> > 
> > I think you should not drop the hint to git send-email as users kept
> > sending patches as attachments.
> 
> Even after patch 2/4 added a trail from contribute.html
> (which was already pointed to by README a couple of lines
> after mentioning git send-email) to hacking.html?
> 
> We have a lot of information about how to use and configure
> git send-email in hacking.html, so I think that people who
> stop at the mention in README without going further and
> reading the full contributor guidelines will botch sending
> the patches in some way regardless. That's why I feel like
> mentioning it there is not very helpful.

Well you are right, somebody stumbling across the mention to git
send-email and using it without reading the docs is basically the same
as if they would not read them and send the patch as attachment.

ACK
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list