[libvirt] [PATCH v3 03/26] conf: Make virDomainPCIAddressFlagsCompatible() private

Andrea Bolognani posted 26 patches 8 years, 7 months ago
[libvirt] [PATCH v3 03/26] conf: Make virDomainPCIAddressFlagsCompatible() private
Posted by Andrea Bolognani 8 years, 7 months ago
There are no external users.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 src/conf/domain_addr.c   | 2 +-
 src/conf/domain_addr.h   | 8 --------
 src/libvirt_private.syms | 1 -
 3 files changed, 1 insertion(+), 10 deletions(-)

diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c
index 9c809e8..0a7cb00 100644
--- a/src/conf/domain_addr.c
+++ b/src/conf/domain_addr.c
@@ -103,7 +103,7 @@ virDomainPCIControllerConnectTypeToModel(virDomainPCIConnectFlags flags)
 }
 
 
-bool
+static bool
 virDomainPCIAddressFlagsCompatible(virPCIDeviceAddressPtr addr,
                                    const char *addrStr,
                                    virDomainPCIConnectFlags busFlags,
diff --git a/src/conf/domain_addr.h b/src/conf/domain_addr.h
index efa97ca..0c7905b 100644
--- a/src/conf/domain_addr.h
+++ b/src/conf/domain_addr.h
@@ -121,14 +121,6 @@ virDomainPCIAddressSetPtr virDomainPCIAddressSetAlloc(unsigned int nbuses);
 
 void virDomainPCIAddressSetFree(virDomainPCIAddressSetPtr addrs);
 
-bool virDomainPCIAddressFlagsCompatible(virPCIDeviceAddressPtr addr,
-                                        const char *addrStr,
-                                        virDomainPCIConnectFlags busFlags,
-                                        virDomainPCIConnectFlags devFlags,
-                                        bool reportError,
-                                        bool fromConfig)
-     ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2);
-
 bool virDomainPCIAddressValidate(virDomainPCIAddressSetPtr addrs,
                                  virPCIDeviceAddressPtr addr,
                                  const char *addrStr,
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index 175370e..c8862a2 100644
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -108,7 +108,6 @@ virDomainGetBlkioParametersAssignFromDef;
 virDomainPCIAddressAsString;
 virDomainPCIAddressBusSetModel;
 virDomainPCIAddressEnsureAddr;
-virDomainPCIAddressFlagsCompatible;
 virDomainPCIAddressReleaseAddr;
 virDomainPCIAddressReserveAddr;
 virDomainPCIAddressReserveNextAddr;
-- 
2.7.5

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v3 03/26] conf: Make virDomainPCIAddressFlagsCompatible() private
Posted by Laine Stump 8 years, 7 months ago
On 06/23/2017 11:03 AM, Andrea Bolognani wrote:
> There are no external users.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>

Reviewed-by: Laine Stump <laine@laine.org>

> ---
>  src/conf/domain_addr.c   | 2 +-
>  src/conf/domain_addr.h   | 8 --------
>  src/libvirt_private.syms | 1 -
>  3 files changed, 1 insertion(+), 10 deletions(-)
> 
> diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c
> index 9c809e8..0a7cb00 100644
> --- a/src/conf/domain_addr.c
> +++ b/src/conf/domain_addr.c
> @@ -103,7 +103,7 @@ virDomainPCIControllerConnectTypeToModel(virDomainPCIConnectFlags flags)
>  }
>  
>  
> -bool
> +static bool
>  virDomainPCIAddressFlagsCompatible(virPCIDeviceAddressPtr addr,
>                                     const char *addrStr,
>                                     virDomainPCIConnectFlags busFlags,
> diff --git a/src/conf/domain_addr.h b/src/conf/domain_addr.h
> index efa97ca..0c7905b 100644
> --- a/src/conf/domain_addr.h
> +++ b/src/conf/domain_addr.h
> @@ -121,14 +121,6 @@ virDomainPCIAddressSetPtr virDomainPCIAddressSetAlloc(unsigned int nbuses);
>  
>  void virDomainPCIAddressSetFree(virDomainPCIAddressSetPtr addrs);
>  
> -bool virDomainPCIAddressFlagsCompatible(virPCIDeviceAddressPtr addr,
> -                                        const char *addrStr,
> -                                        virDomainPCIConnectFlags busFlags,
> -                                        virDomainPCIConnectFlags devFlags,
> -                                        bool reportError,
> -                                        bool fromConfig)
> -     ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2);
> -
>  bool virDomainPCIAddressValidate(virDomainPCIAddressSetPtr addrs,
>                                   virPCIDeviceAddressPtr addr,
>                                   const char *addrStr,
> diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
> index 175370e..c8862a2 100644
> --- a/src/libvirt_private.syms
> +++ b/src/libvirt_private.syms
> @@ -108,7 +108,6 @@ virDomainGetBlkioParametersAssignFromDef;
>  virDomainPCIAddressAsString;
>  virDomainPCIAddressBusSetModel;
>  virDomainPCIAddressEnsureAddr;
> -virDomainPCIAddressFlagsCompatible;
>  virDomainPCIAddressReleaseAddr;
>  virDomainPCIAddressReserveAddr;
>  virDomainPCIAddressReserveNextAddr;
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list