vz: fix typo that breaks build

[libvirt] [PATCH] vz: fix typo that breaks build

Posted by Nikolay Shirokovskiy 7 years ago

---

I guess it should be back ported to 3.2.0 release too. Sorry that
we missed this during freeze period.

 src/vz/vz_driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c
index bb1afd0..da83a8f 100644
--- a/src/vz/vz_driver.c
+++ b/src/vz/vz_driver.c
@@ -121,7 +121,7 @@ vzBuildCapabilities(void)
 
     verify(ARRAY_CARDINALITY(archs) == ARRAY_CARDINALITY(emulators));
 
-    for (i = 0; i < ARRAY_CARDINALITY(os_types); i++)
+    for (i = 0; i < ARRAY_CARDINALITY(ostypes); i++)
         for (j = 0; j < ARRAY_CARDINALITY(archs); j++)
             for (k = 0; k < ARRAY_CARDINALITY(emulators); k++)
                 if (vzCapsAddGuestDomain(caps, ostypes[i], archs[j],
-- 
1.8.3.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] vz: fix typo that breaks build

Posted by Martin Kletzander 7 years ago

On Tue, Apr 04, 2017 at 01:02:21PM +0300, Nikolay Shirokovskiy wrote:
>---
>
>I guess it should be back ported to 3.2.0 release too. Sorry that
>we missed this during freeze period.
>

I'm really sorry for that.  I thought I'm building with VZ, but the
driver renaming and names are confusing, so I guess I am not (since that
didn't fail for me).  That also means we don't

Anyway, ACK to this, I will push it in both master and into v3.2-maint
so it gets released as v3.2.1.

> src/vz/vz_driver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c
>index bb1afd0..da83a8f 100644
>--- a/src/vz/vz_driver.c
>+++ b/src/vz/vz_driver.c
>@@ -121,7 +121,7 @@ vzBuildCapabilities(void)
>
>     verify(ARRAY_CARDINALITY(archs) == ARRAY_CARDINALITY(emulators));
>
>-    for (i = 0; i < ARRAY_CARDINALITY(os_types); i++)
>+    for (i = 0; i < ARRAY_CARDINALITY(ostypes); i++)
>         for (j = 0; j < ARRAY_CARDINALITY(archs); j++)
>             for (k = 0; k < ARRAY_CARDINALITY(emulators); k++)
>                 if (vzCapsAddGuestDomain(caps, ostypes[i], archs[j],
>--
>1.8.3.1
>
>--
>libvir-list mailing list
>libvir-list@redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] vz: fix typo that breaks build

Posted by Nikolay Shirokovskiy 7 years ago


On 04.04.2017 15:46, Martin Kletzander wrote:
> On Tue, Apr 04, 2017 at 01:02:21PM +0300, Nikolay Shirokovskiy wrote:
>> ---
>>
>> I guess it should be back ported to 3.2.0 release too. Sorry that
>> we missed this during freeze period.
>>
> 
> I'm really sorry for that.  I thought I'm building with VZ, but the
> driver renaming and names are confusing, so I guess I am not (since that
> didn't fail for me).  That also means we don't
> 
> Anyway, ACK to this, I will push it in both master and into v3.2-maint
> so it gets released as v3.2.1.
> 

Thanx!

>> src/vz/vz_driver.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c
>> index bb1afd0..da83a8f 100644
>> --- a/src/vz/vz_driver.c
>> +++ b/src/vz/vz_driver.c
>> @@ -121,7 +121,7 @@ vzBuildCapabilities(void)
>>
>>     verify(ARRAY_CARDINALITY(archs) == ARRAY_CARDINALITY(emulators));
>>
>> -    for (i = 0; i < ARRAY_CARDINALITY(os_types); i++)
>> +    for (i = 0; i < ARRAY_CARDINALITY(ostypes); i++)
>>         for (j = 0; j < ARRAY_CARDINALITY(archs); j++)
>>             for (k = 0; k < ARRAY_CARDINALITY(emulators); k++)
>>                 if (vzCapsAddGuestDomain(caps, ostypes[i], archs[j],
>> -- 
>> 1.8.3.1
>>
>> -- 
>> libvir-list mailing list
>> libvir-list@redhat.com
>> https://www.redhat.com/mailman/listinfo/libvir-list

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list