[libvirt] [PATCH] remote: Make Upper limit on list of memory parameters to 64

Nitesh Konkar posted 1 patch 7 years, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/1489661631-15336-1-git-send-email-niteshkonkar.libvirt@gmail.com
src/remote/remote_protocol.x | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[libvirt] [PATCH] remote: Make Upper limit on list of memory parameters to 64
Posted by Nitesh Konkar 7 years, 1 month ago
'virsh perf domain' errors out as the number of perf
events now exceeds the previous memory parameter limit
of 16. The fix is to  set it to 64, as the upper limit
on list of perf events, is also set to the same.

Signed-off-by: Nitesh Konkar <nitkon12@linux.vnet.ibm.com>
---
 src/remote/remote_protocol.x | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x
index abe63af..fd6f3af 100644
--- a/src/remote/remote_protocol.x
+++ b/src/remote/remote_protocol.x
@@ -101,7 +101,7 @@ const REMOTE_DOMAIN_SCHEDULER_PARAMETERS_MAX = 16;
 const REMOTE_DOMAIN_BLKIO_PARAMETERS_MAX = 16;
 
 /* Upper limit on list of memory parameters. */
-const REMOTE_DOMAIN_MEMORY_PARAMETERS_MAX = 16;
+const REMOTE_DOMAIN_MEMORY_PARAMETERS_MAX = 64;
 
 /* Upper limit on list of blockio tuning parameters. */
 const REMOTE_DOMAIN_BLOCK_IO_TUNE_PARAMETERS_MAX = 32;
-- 
1.9.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] remote: Make Upper limit on list of memory parameters to 64
Posted by Daniel P. Berrange 7 years, 1 month ago
On Thu, Mar 16, 2017 at 04:23:51PM +0530, Nitesh Konkar wrote:
> 'virsh perf domain' errors out as the number of perf
> events now exceeds the previous memory parameter limit
> of 16. The fix is to  set it to 64, as the upper limit
> on list of perf events, is also set to the same.

This makes no sense.

'virsh perf' calls virDomainGetPerfEvents & virDomainSetPerfEvents.

These APIs use the constant REMOTE_DOMAIN_PERF_EVENTS_MAX not
REMOTE_DOMAIN_MEMORY_PARAMETERS_MAX

> 
> Signed-off-by: Nitesh Konkar <nitkon12@linux.vnet.ibm.com>
> ---
>  src/remote/remote_protocol.x | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x
> index abe63af..fd6f3af 100644
> --- a/src/remote/remote_protocol.x
> +++ b/src/remote/remote_protocol.x
> @@ -101,7 +101,7 @@ const REMOTE_DOMAIN_SCHEDULER_PARAMETERS_MAX = 16;
>  const REMOTE_DOMAIN_BLKIO_PARAMETERS_MAX = 16;
>  
>  /* Upper limit on list of memory parameters. */
> -const REMOTE_DOMAIN_MEMORY_PARAMETERS_MAX = 16;
> +const REMOTE_DOMAIN_MEMORY_PARAMETERS_MAX = 64;
>  
>  /* Upper limit on list of blockio tuning parameters. */
>  const REMOTE_DOMAIN_BLOCK_IO_TUNE_PARAMETERS_MAX = 32;
> -- 
> 1.9.3
> 

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list