[libvirt] [PATCH 1/2] vz: fix handle leak in prlsdkHandleVmStateEvent

Maxim Nestratov posted 2 patches 9 years ago
[libvirt] [PATCH 1/2] vz: fix handle leak in prlsdkHandleVmStateEvent
Posted by Maxim Nestratov 9 years ago
Every successful call of PrlEvent_GetParamByName allocates a handle,
which has to be freed.

Signed-off-by: Maxim Nestratov <mnestratov@virtuozzo.com>
---
 src/vz/vz_sdk.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c
index 727b572..ec954dd 100644
--- a/src/vz/vz_sdk.c
+++ b/src/vz/vz_sdk.c
@@ -2114,6 +2114,7 @@ prlsdkHandleVmStateEvent(vzDriverPtr driver,
     prlsdkSendEvent(driver, dom, lvEventType, lvEventTypeDetails);
 
  cleanup:
+    PrlHandle_Free(eventParam);
     virObjectUnlock(dom);
     return;
 }
-- 
2.4.11

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 1/2] vz: fix handle leak in prlsdkHandleVmStateEvent
Posted by Daniel P. Berrange 9 years ago
On Wed, Feb 08, 2017 at 06:28:33PM +0300, Maxim Nestratov wrote:
> Every successful call of PrlEvent_GetParamByName allocates a handle,
> which has to be freed.
> 
> Signed-off-by: Maxim Nestratov <mnestratov@virtuozzo.com>
> ---
>  src/vz/vz_sdk.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c
> index 727b572..ec954dd 100644
> --- a/src/vz/vz_sdk.c
> +++ b/src/vz/vz_sdk.c
> @@ -2114,6 +2114,7 @@ prlsdkHandleVmStateEvent(vzDriverPtr driver,
>      prlsdkSendEvent(driver, dom, lvEventType, lvEventTypeDetails);
>  
>   cleanup:
> +    PrlHandle_Free(eventParam);
>      virObjectUnlock(dom);
>      return;
>  }

ACK

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list