Remove additional newline from virsh-domain-monitor.c

[libvirt] [PATCH] Remove additional newline from virsh-domain-monitor.c

Nitesh Konkar posted 1 patch 7 years, 2 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/1486543849-30249-1-git-send-email-niteshkonkar.libvirt@gmail.com

tools/virsh-domain-monitor.c | 1 -
1 file changed, 1 deletion(-)

Expand all Fold all

[libvirt] [PATCH] Remove additional newline from virsh-domain-monitor.c

Posted by Nitesh Konkar 7 years, 2 months ago

Currently "virsh domstats domainName" result ends
with two blanklines. This shall remove the additional
blank line.

Signed-off-by: Nitesh Konkar <nitkon12@linux.vnet.ibm.com>
---
 tools/virsh-domain-monitor.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c
index 77aa272..c558819 100644
--- a/tools/virsh-domain-monitor.c
+++ b/tools/virsh-domain-monitor.c
@@ -2047,7 +2047,6 @@ virshDomainStatsPrintRecord(vshControl *ctl ATTRIBUTE_UNUSED,
         VIR_FREE(param);
     }
 
-    vshPrint(ctl, "\n");
     return true;
 }
 
-- 
1.9.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Remove additional newline from virsh-domain-monitor.c

Posted by Peter Krempa 7 years, 2 months ago

On Wed, Feb 08, 2017 at 14:20:49 +0530, Nitesh Konkar wrote:
> Currently "virsh domstats domainName" result ends
> with two blanklines. This shall remove the additional
> blank line.
> 
> Signed-off-by: Nitesh Konkar <nitkon12@linux.vnet.ibm.com>
> ---
>  tools/virsh-domain-monitor.c | 1 -
>  1 file changed, 1 deletion(-)

NACK,

if you use virsh domstats to report stats for multiple VMs then the
output would not be separated any more:

Domain: 'hp'
  state.state=5
  state.reason=0
  balloon.maximum=1024000
  vcpu.current=2
  vcpu.maximum=10
  block.count=1
  block.0.name=hda
  block.0.path=/tmp/ble.img
Domain: 'rhel7.2-2'
  state.state=5
  state.reason=0
  balloon.maximum=1048576
  vcpu.current=2
  vcpu.maximum=8
  block.count=0
Domain: 'rhel7.2'
  state.state=5
  state.reason=0
  balloon.maximum=2097152
  vcpu.current=2
  vcpu.maximum=2
  block.count=1
  block.0.name=vda
  block.0.path=/var/lib/libvirt/images/rhel7.2.qcow2
  block.0.allocation=9665384448
  block.0.capacity=9663676416
  block.0.physical=9665380352

The only option would be if you skip it for the last entry.


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list