[libvirt] [PATCH v3 0/3] network: make openvswitch call timeout configurable

Boris Fiuczynski posted 3 patches 7 years, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/1486480604-29957-1-git-send-email-fiuczy@linux.vnet.ibm.com
daemon/libvirtd-config.c        |  6 ++++
daemon/libvirtd-config.h        |  2 ++
daemon/libvirtd.aug             |  1 +
daemon/libvirtd.c               | 13 +++++++++
daemon/libvirtd.conf            |  9 ++++++
daemon/test_libvirtd.aug.in     |  1 +
src/libvirt_private.syms        |  1 +
src/util/virnetdevopenvswitch.c | 64 +++++++++++++++++++++++++++++++++++------
src/util/virnetdevopenvswitch.h |  5 ++++
9 files changed, 94 insertions(+), 8 deletions(-)
[libvirt] [PATCH v3 0/3] network: make openvswitch call timeout configurable
Posted by Boris Fiuczynski 7 years, 1 month ago
Since a successful completion of openvswitch calls is expected a longer
timeout should be able to be chosen in order to account for loaded systems.
Therefore this patch series provides the ability to specify the timeout value
for openvswitch calls in the libvirtd configuration file.


Boris Fiuczynski (3):
  libvirtd: add openvitch timeout value
  network: allow to specify timeout for openvswitch calls
  libvirtd: set openvswitch timeout value based on config data

 daemon/libvirtd-config.c        |  6 ++++
 daemon/libvirtd-config.h        |  2 ++
 daemon/libvirtd.aug             |  1 +
 daemon/libvirtd.c               | 13 +++++++++
 daemon/libvirtd.conf            |  9 ++++++
 daemon/test_libvirtd.aug.in     |  1 +
 src/libvirt_private.syms        |  1 +
 src/util/virnetdevopenvswitch.c | 64 +++++++++++++++++++++++++++++++++++------
 src/util/virnetdevopenvswitch.h |  5 ++++
 9 files changed, 94 insertions(+), 8 deletions(-)

-- 
2.5.5

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v3 0/3] network: make openvswitch call timeout configurable
Posted by Michal Privoznik 7 years, 1 month ago
On 02/07/2017 04:16 PM, Boris Fiuczynski wrote:
> Since a successful completion of openvswitch calls is expected a longer
> timeout should be able to be chosen in order to account for loaded systems.
> Therefore this patch series provides the ability to specify the timeout value
> for openvswitch calls in the libvirtd configuration file.
> 
> 
> Boris Fiuczynski (3):
>   libvirtd: add openvitch timeout value
>   network: allow to specify timeout for openvswitch calls
>   libvirtd: set openvswitch timeout value based on config data
> 
>  daemon/libvirtd-config.c        |  6 ++++
>  daemon/libvirtd-config.h        |  2 ++
>  daemon/libvirtd.aug             |  1 +
>  daemon/libvirtd.c               | 13 +++++++++
>  daemon/libvirtd.conf            |  9 ++++++
>  daemon/test_libvirtd.aug.in     |  1 +
>  src/libvirt_private.syms        |  1 +
>  src/util/virnetdevopenvswitch.c | 64 +++++++++++++++++++++++++++++++++++------
>  src/util/virnetdevopenvswitch.h |  5 ++++
>  9 files changed, 94 insertions(+), 8 deletions(-)
> 

I've fixed all the issues I've found and was about to push it. But then
I realized: docs/news.xml entry is missing. I can't push it without it,
sorry. I can't do it to our news police :-) Just reply with proposed
news entry and I can fix that.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v3 0/3] network: make openvswitch call timeout configurable
Posted by Boris Fiuczynski 7 years, 1 month ago
On 02/09/2017 09:01 AM, Michal Privoznik wrote:
> On 02/07/2017 04:16 PM, Boris Fiuczynski wrote:
>> Since a successful completion of openvswitch calls is expected a longer
>> timeout should be able to be chosen in order to account for loaded systems.
>> Therefore this patch series provides the ability to specify the timeout value
>> for openvswitch calls in the libvirtd configuration file.
>>
>>
>> Boris Fiuczynski (3):
>>   libvirtd: add openvitch timeout value
>>   network: allow to specify timeout for openvswitch calls
>>   libvirtd: set openvswitch timeout value based on config data
>>
>>  daemon/libvirtd-config.c        |  6 ++++
>>  daemon/libvirtd-config.h        |  2 ++
>>  daemon/libvirtd.aug             |  1 +
>>  daemon/libvirtd.c               | 13 +++++++++
>>  daemon/libvirtd.conf            |  9 ++++++
>>  daemon/test_libvirtd.aug.in     |  1 +
>>  src/libvirt_private.syms        |  1 +
>>  src/util/virnetdevopenvswitch.c | 64 +++++++++++++++++++++++++++++++++++------
>>  src/util/virnetdevopenvswitch.h |  5 ++++
>>  9 files changed, 94 insertions(+), 8 deletions(-)
>>
>
> I've fixed all the issues I've found and was about to push it. But then
> I realized: docs/news.xml entry is missing. I can't push it without it,
> sorry. I can't do it to our news police :-) Just reply with proposed
> news entry and I can fix that.
>
> Michal
>
Well, it was worth a try... Just kidding! :-)
It's a miss on my side. Sorry about it.
Here is my proposal:

       <change>
         <summary>
           network: make openvswitch call timeout configurable
         </summary>
         <description>
           Adding the ability to specify the timeout value in seconds for
           openvswitch calls in the libvirtd configuration file.
         </description>
       </change>

or in patch-like format

 From b148e8f512aefbcbb68aaba6b6873feb2bccfede Mon Sep 17 00:00:00 2001
From: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com>
Date: Thu, 9 Feb 2017 14:08:53 +0100
Subject: [PATCH] news: that I forgot to add

Signed-off-by: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com>
---
  docs/news.xml | 9 +++++++++
  1 file changed, 9 insertions(+)

diff --git a/docs/news.xml b/docs/news.xml
index 69ed6a7..d1ca497 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -43,6 +43,15 @@
            and network.
          </description>
        </change>
+      <change>
+        <summary>
+          network: make openvswitch call timeout configurable
+        </summary>
+        <description>
+          Adding the ability to specify the timeout value in seconds for
+          openvswitch calls in the libvirtd configuration file.
+        </description>
+      </change>
      </section>
      <section title="Bug fixes">
        <change>
--
2.5.5



-- 
Mit freundlichen Grüßen/Kind regards
    Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martina Köderitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v3 0/3] network: make openvswitch call timeout configurable
Posted by Michal Privoznik 7 years, 1 month ago
On 02/09/2017 04:21 PM, Boris Fiuczynski wrote:
> On 02/09/2017 09:01 AM, Michal Privoznik wrote:
>> On 02/07/2017 04:16 PM, Boris Fiuczynski wrote:
>>> Since a successful completion of openvswitch calls is expected a longer
>>> timeout should be able to be chosen in order to account for loaded
>>> systems.
>>> Therefore this patch series provides the ability to specify the
>>> timeout value
>>> for openvswitch calls in the libvirtd configuration file.
>>>
>>>
>>> Boris Fiuczynski (3):
>>>   libvirtd: add openvitch timeout value
>>>   network: allow to specify timeout for openvswitch calls
>>>   libvirtd: set openvswitch timeout value based on config data
>>>
>>>  daemon/libvirtd-config.c        |  6 ++++
>>>  daemon/libvirtd-config.h        |  2 ++
>>>  daemon/libvirtd.aug             |  1 +
>>>  daemon/libvirtd.c               | 13 +++++++++
>>>  daemon/libvirtd.conf            |  9 ++++++
>>>  daemon/test_libvirtd.aug.in     |  1 +
>>>  src/libvirt_private.syms        |  1 +
>>>  src/util/virnetdevopenvswitch.c | 64
>>> +++++++++++++++++++++++++++++++++++------
>>>  src/util/virnetdevopenvswitch.h |  5 ++++
>>>  9 files changed, 94 insertions(+), 8 deletions(-)
>>>
>>
>> I've fixed all the issues I've found and was about to push it. But then
>> I realized: docs/news.xml entry is missing. I can't push it without it,
>> sorry. I can't do it to our news police :-) Just reply with proposed
>> news entry and I can fix that.
>>
>> Michal
>>
> Well, it was worth a try... Just kidding! :-)

Ha ha.

> It's a miss on my side. Sorry about it.

No problem. It's a new concept. Even us, full time contributors often
forget about that.

> Here is my proposal:
> 
>       <change>
>         <summary>
>           network: make openvswitch call timeout configurable
>         </summary>
>         <description>
>           Adding the ability to specify the timeout value in seconds for
>           openvswitch calls in the libvirtd configuration file.
>         </description>
>       </change>

Yeah, this will do.

Pushed. Thanks.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list