[v1] docs: secret: do not use a valuable password

[libvirt PATCH] docs: secret: do not use a valuable password

Ján Tomko posted 1 patch 3 years ago

Diff against v2
Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/080833123fa96cfdf774eda5fa922d5dff95c62a.1617278494.git.jtomko@redhat.com

There is a newer version of this series

docs/formatsecret.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[libvirt PATCH] docs: secret: do not use a valuable password

Posted by Ján Tomko 3 years ago

Our website displays "**** ******" as the example password.
Despite its tradition rooted in 18th century French literature,
we cannot assume it to be public.

Use a random string of letters and numbers instead.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 docs/formatsecret.html.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/formatsecret.html.in b/docs/formatsecret.html.in
index 9dc9cdf288..19613cb5dc 100644
--- a/docs/formatsecret.html.in
+++ b/docs/formatsecret.html.in
@@ -405,7 +405,7 @@ Secret value set
     </p>
 
     <pre>
-# MYSECRET=`printf %s "open sesame" | base64`
+# MYSECRET=`printf %s "dQw4w9WgXcQ" | base64`
 # virsh secret-set-value 6dd3e4a5-1d76-44ce-961f-f119f5aad935 $MYSECRET
 Secret value set
     </pre>
-- 
2.29.2

Re: [libvirt PATCH] docs: secret: do not use a valuable password

Posted by Erik Skultety 3 years ago

On Thu, Apr 01, 2021 at 02:02:01PM +0200, Ján Tomko wrote:
> Our website displays "**** ******" as the example password.
> Despite its tradition rooted in 18th century French literature,
> we cannot assume it to be public.
> 
> Use a random string of letters and numbers instead.
> 
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>  docs/formatsecret.html.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/docs/formatsecret.html.in b/docs/formatsecret.html.in
> index 9dc9cdf288..19613cb5dc 100644
> --- a/docs/formatsecret.html.in
> +++ b/docs/formatsecret.html.in
> @@ -405,7 +405,7 @@ Secret value set
>      </p>
>  
>      <pre>
> -# MYSECRET=`printf %s "open sesame" | base64`
> +# MYSECRET=`printf %s "dQw4w9WgXcQ" | base64`

NACK, hunter2 is preferrable.

Regards,
Erik