virQEMUDriverConfigNew: Add slash to cfg->defaultTLSx509certdir for non-embedded driver

[PATCH] virQEMUDriverConfigNew: Add slash to cfg->defaultTLSx509certdir for non-embedded driver

Peter Krempa posted 1 patch 3 years, 10 months ago

Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/071b6f39048b7a67a7658f62472503c7b8bc2f9d.1592303923.git.pkrempa@redhat.com

src/qemu/qemu_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] virQEMUDriverConfigNew: Add slash to cfg->defaultTLSx509certdir for non-embedded driver

Posted by Peter Krempa 3 years, 10 months ago

Commit 068efae5b1a9ef accidentally removed the slash.

https://bugzilla.redhat.com/show_bug.cgi?id=1847234

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_conf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index b49299e1de..33b3989268 100644
--- a/src/qemu/qemu_conf.c
+++ b/src/qemu/qemu_conf.c
@@ -234,7 +234,7 @@ virQEMUDriverConfigPtr virQEMUDriverConfigNew(bool privileged,
      * directory doesn't exist (although we don't check if this exists).
      */
     if (root == NULL) {
-        cfg->defaultTLSx509certdir = g_strdup(SYSCONFDIR "pki/qemu");
+        cfg->defaultTLSx509certdir = g_strdup(SYSCONFDIR "/pki/qemu");
     } else {
         cfg->defaultTLSx509certdir = g_strdup_printf("%s/etc/pki/qemu", root);
     }
-- 
2.26.2

Re: [PATCH] virQEMUDriverConfigNew: Add slash to cfg->defaultTLSx509certdir for non-embedded driver

Posted by Andrea Bolognani 3 years, 10 months ago

On Tue, 2020-06-16 at 12:38 +0200, Peter Krempa wrote:
> Commit 068efae5b1a9ef accidentally removed the slash.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1847234
> 
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>  src/qemu/qemu_conf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization