[PATCH] qemu-replies-tool: Fix logic error when dumping device properties

Peter Krempa via Devel posted 1 patch 2 weeks, 4 days ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/05eae213f0f16e491b3bb27de5a5ded4b4f8359e.1759840371.git.pkrempa@redhat.com
scripts/qemu-replies-tool.py | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
[PATCH] qemu-replies-tool: Fix logic error when dumping device properties
Posted by Peter Krempa via Devel 2 weeks, 4 days ago
From: Peter Krempa <pkrempa@redhat.com>

In a recent refactor the block of code outputting device properties was
mis-indented causing it to only work on device properties which have no
'default-value'.

Fixes: 301e1ba244f
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 scripts/qemu-replies-tool.py | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/scripts/qemu-replies-tool.py b/scripts/qemu-replies-tool.py
index cf99ecd1f3..21401452cf 100755
--- a/scripts/qemu-replies-tool.py
+++ b/scripts/qemu-replies-tool.py
@@ -436,16 +436,16 @@ def dump_device_and_object_properties(conv, dumpprefix):
                 if k not in ['name', 'type', 'description', 'default-value']:
                     raise Exception("Unhandled 'device-list-properties'/'qom-list-properties' typename '%s' field '%s'" % (c['cmd']['arguments']['typename'], k))

-                if 'default-value' in arg:
-                    defval = ' (%s)' % str(arg['default-value'])
-                else:
-                    defval = ''
-
-                    ent.append('%s %s %s %s%s' % (prefix,
-                                                  c['cmd']['arguments']['typename'],
-                                                  arg['name'],
-                                                  arg['type'],
-                                                  defval))
+            if 'default-value' in arg:
+                defval = ' (%s)' % str(arg['default-value'])
+            else:
+                defval = ''
+
+            ent.append('%s %s %s %s%s' % (prefix,
+                                          c['cmd']['arguments']['typename'],
+                                          arg['name'],
+                                          arg['type'],
+                                          defval))
     ent.sort()

     for e in ent:
-- 
2.51.0
Re: [PATCH] qemu-replies-tool: Fix logic error when dumping device properties
Posted by Ján Tomko via Devel 2 weeks, 4 days ago
On a Tuesday in 2025, Peter Krempa via Devel wrote:
>From: Peter Krempa <pkrempa@redhat.com>
>
>In a recent refactor the block of code outputting device properties was
>mis-indented causing it to only work on device properties which have no
>'default-value'.
>
>Fixes: 301e1ba244f
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> scripts/qemu-replies-tool.py | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano