Get server arch from /config Wok API instead of relying on Ginger Base

[Kimchi-devel] [PATCH] [Kimchi] Get server arch from /config Wok API instead of relying on Ginger Base

Posted by Aline Manera 7 years, 4 months ago

That is one more change related to remove Ginger Base dependency from
Kimchi.

Signed-off-by: Aline Manera <alinefm@linux.vnet.ibm.com>
---

This patch depends on Wok patch [PATCH] [Wok] Add system arch to /config API

---
 ui/js/src/kimchi.api.js  | 4 ++--
 ui/js/src/kimchi.main.js | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/ui/js/src/kimchi.api.js b/ui/js/src/kimchi.api.js
index 1cb89c0..27e3187 100644
--- a/ui/js/src/kimchi.api.js
+++ b/ui/js/src/kimchi.api.js
@@ -1314,9 +1314,9 @@ var kimchi = {
     * Get the host information.
     */
 
-    kimchi.getHostDetails = function(suc, err) {
+    kimchi.serverConfig = function(suc, err) {
         wok.requestJSON({
-          url: 'plugins/gingerbase/host',
+          url: 'config',
           type: 'GET',
           resend: true,
           contentType: 'application/json',
diff --git a/ui/js/src/kimchi.main.js b/ui/js/src/kimchi.main.js
index f3078ec..f64b209 100644
--- a/ui/js/src/kimchi.main.js
+++ b/ui/js/src/kimchi.main.js
@@ -34,8 +34,8 @@ kimchi.getCapabilities(function(result) {
 });
 
 kimchi.hostarch = undefined;
-kimchi.getHostDetails(function(result) {
-    kimchi.hostarch = result["architecture"];
+kimchi.serverConfig(function(result) {
+    kimchi.hostarch = result["arch"];
 });
 
 $(function(){
-- 
2.9.3

_______________________________________________
Kimchi-devel mailing list
Kimchi-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel

Re: [Kimchi-devel] [PATCH] [Kimchi] Get server arch from /config Wok API instead of relying on Ginger Base

Posted by Daniel Henrique Barboza 7 years, 4 months ago

Reviewed-by: Daniel Barboza <danielhb@linux.vnet.ibm.com>


On 04/25/2017 04:26 PM, Aline Manera wrote:
> That is one more change related to remove Ginger Base dependency from
> Kimchi.
>
> Signed-off-by: Aline Manera <alinefm@linux.vnet.ibm.com>
> ---
>
> This patch depends on Wok patch [PATCH] [Wok] Add system arch to /config API
>
> ---
>   ui/js/src/kimchi.api.js  | 4 ++--
>   ui/js/src/kimchi.main.js | 4 ++--
>   2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/ui/js/src/kimchi.api.js b/ui/js/src/kimchi.api.js
> index 1cb89c0..27e3187 100644
> --- a/ui/js/src/kimchi.api.js
> +++ b/ui/js/src/kimchi.api.js
> @@ -1314,9 +1314,9 @@ var kimchi = {
>       * Get the host information.
>       */
>   
> -    kimchi.getHostDetails = function(suc, err) {
> +    kimchi.serverConfig = function(suc, err) {
>           wok.requestJSON({
> -          url: 'plugins/gingerbase/host',
> +          url: 'config',
>             type: 'GET',
>             resend: true,
>             contentType: 'application/json',
> diff --git a/ui/js/src/kimchi.main.js b/ui/js/src/kimchi.main.js
> index f3078ec..f64b209 100644
> --- a/ui/js/src/kimchi.main.js
> +++ b/ui/js/src/kimchi.main.js
> @@ -34,8 +34,8 @@ kimchi.getCapabilities(function(result) {
>   });
>   
>   kimchi.hostarch = undefined;
> -kimchi.getHostDetails(function(result) {
> -    kimchi.hostarch = result["architecture"];
> +kimchi.serverConfig(function(result) {
> +    kimchi.hostarch = result["arch"];
>   });
>   
>   $(function(){

_______________________________________________
Kimchi-devel mailing list
Kimchi-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel

Re: [Kimchi-devel] [PATCH] [Kimchi] Get server arch from /config Wok API instead of relying on Ginger Base

Posted by Aline Manera 7 years, 4 months ago

Hi all,

I will send another version of this patch which adds arch to /host 
Kimchi API instead of changing Wok /config API

On 04/25/2017 04:26 PM, Aline Manera wrote:
> That is one more change related to remove Ginger Base dependency from
> Kimchi.
>
> Signed-off-by: Aline Manera <alinefm@linux.vnet.ibm.com>
> ---
>
> This patch depends on Wok patch [PATCH] [Wok] Add system arch to /config API
>
> ---
>   ui/js/src/kimchi.api.js  | 4 ++--
>   ui/js/src/kimchi.main.js | 4 ++--
>   2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/ui/js/src/kimchi.api.js b/ui/js/src/kimchi.api.js
> index 1cb89c0..27e3187 100644
> --- a/ui/js/src/kimchi.api.js
> +++ b/ui/js/src/kimchi.api.js
> @@ -1314,9 +1314,9 @@ var kimchi = {
>       * Get the host information.
>       */
>
> -    kimchi.getHostDetails = function(suc, err) {
> +    kimchi.serverConfig = function(suc, err) {
>           wok.requestJSON({
> -          url: 'plugins/gingerbase/host',
> +          url: 'config',
>             type: 'GET',
>             resend: true,
>             contentType: 'application/json',
> diff --git a/ui/js/src/kimchi.main.js b/ui/js/src/kimchi.main.js
> index f3078ec..f64b209 100644
> --- a/ui/js/src/kimchi.main.js
> +++ b/ui/js/src/kimchi.main.js
> @@ -34,8 +34,8 @@ kimchi.getCapabilities(function(result) {
>   });
>
>   kimchi.hostarch = undefined;
> -kimchi.getHostDetails(function(result) {
> -    kimchi.hostarch = result["architecture"];
> +kimchi.serverConfig(function(result) {
> +    kimchi.hostarch = result["arch"];
>   });
>
>   $(function(){

_______________________________________________
Kimchi-devel mailing list
Kimchi-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel