[v1] OvmfPkg: Update I/O port related to ACPI devices for CloudHv

[edk2-devel] [PATCH] OvmfPkg: Update I/O port related to ACPI devices for CloudHv

Posted by Boeuf, Sebastien 1 year, 8 months ago

From: Sebastien Boeuf <sebastien.boeuf@intel.com>

Both ACPI shutdown and ACPI PM timer devices has been moved to different
port addresses in the latest version of Cloud Hypervisor. These changes
need to be reflected on the OVMF firmware.

Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
---
 OvmfPkg/Include/IndustryStandard/CloudHv.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/OvmfPkg/Include/IndustryStandard/CloudHv.h b/OvmfPkg/Include/IndustryStandard/CloudHv.h
index d31ecc9eec..527c236f48 100644
--- a/OvmfPkg/Include/IndustryStandard/CloudHv.h
+++ b/OvmfPkg/Include/IndustryStandard/CloudHv.h
@@ -16,12 +16,12 @@
 //
 // ACPI timer address
 //
-#define CLOUDHV_ACPI_TIMER_IO_ADDRESS  0xb008
+#define CLOUDHV_ACPI_TIMER_IO_ADDRESS  0x0608
 
 //
 // ACPI shutdown device address
 //
-#define CLOUDHV_ACPI_SHUTDOWN_IO_ADDRESS  0x03c0
+#define CLOUDHV_ACPI_SHUTDOWN_IO_ADDRESS  0x0600
 
 //
 // 32-bit MMIO memory hole base address
-- 
2.34.1

---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris, 
92196 Meudon Cedex, France
Registration Number:  302 456 199 R.C.S. NANTERRE
Capital: 5 208 026.16 Euros

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92379): https://edk2.groups.io/g/devel/message/92379
Mute This Topic: https://groups.io/mt/92957046/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] OvmfPkg: Update I/O port related to ACPI devices for CloudHv

Posted by Gerd Hoffmann 1 year, 8 months ago

On Thu, Aug 11, 2022 at 02:40:57PM +0200, Boeuf, Sebastien wrote:
> From: Sebastien Boeuf <sebastien.boeuf@intel.com>
> 
> Both ACPI shutdown and ACPI PM timer devices has been moved to different
> port addresses in the latest version of Cloud Hypervisor. These changes
> need to be reflected on the OVMF firmware.

Can this be detected by the guest somehow, so the firmware can work with
both old+new cloudhv?

Requiring lockstep updates tends to be painful, so we try avoid that
with qemu ...

(just a suggestion, not an objection)

Acked-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92427): https://edk2.groups.io/g/devel/message/92427
Mute This Topic: https://groups.io/mt/92957046/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] OvmfPkg: Update I/O port related to ACPI devices for CloudHv

Posted by Boeuf, Sebastien 1 year, 8 months ago

On Mon, 2022-08-15 at 15:49 +0200, Gerd Hoffmann wrote:
> On Thu, Aug 11, 2022 at 02:40:57PM +0200, Boeuf, Sebastien wrote:
> > From: Sebastien Boeuf <sebastien.boeuf@intel.com>
> > 
> > Both ACPI shutdown and ACPI PM timer devices has been moved to
> > different
> > port addresses in the latest version of Cloud Hypervisor. These
> > changes
> > need to be reflected on the OVMF firmware.
> 
> Can this be detected by the guest somehow, so the firmware can work
> with
> both old+new cloudhv?

This information is provided through the FADT/FACP as well, which is
where the OS retrieves it.

> 
> Requiring lockstep updates tends to be painful, so we try avoid that
> with qemu ...

Yes I understand. We've been kind of forced to update these addresses
to match the ones used by QEMU since they had already been authorized
in the context of TDX. It's just easier for everybody.

> 
> (just a suggestion, not an objection)
> 
> Acked-by: Gerd Hoffmann <kraxel@redhat.com>
> 
> take care,
>   Gerd
> 
> 
> 
> 
> 
> 

---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris, 
92196 Meudon Cedex, France
Registration Number:  302 456 199 R.C.S. NANTERRE
Capital: 5 208 026.16 Euros

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92578): https://edk2.groups.io/g/devel/message/92578
Mute This Topic: https://groups.io/mt/92957046/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-