1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [PATCH] MdeModulePkg: Correct the variable name.

gechao@greatwall.com.cn posted 1 patch 3 years, 5 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/edk2 tags/patchew/e0e609fcc2dddcd9f45f9fc2e11bfba030717e76.1604316574.git.gechao@greatwall.com.cn
.../Universal/DisplayEngineDxe/FormDisplay.c     | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
[edk2-devel] [PATCH] MdeModulePkg: Correct the variable name.
Posted by gechao@greatwall.com.cn 3 years, 5 months ago 
From: gechao <gechao@greatwall.com.cn>

Signed-off-by: gechao <gechao@greatwall.com.cn>
---
 .../Universal/DisplayEngineDxe/FormDisplay.c     | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c b/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c
index 3b034a1c82..a3898dc2ec 100644
--- a/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c
+++ b/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c
@@ -372,7 +372,7 @@ GetWidth (
 {
   CHAR16                        *String;
   UINTN                         Size;
-  EFI_IFR_TEXT                  *TestOp;
+  EFI_IFR_TEXT                  *TextOp;
   UINT16                        ReturnWidth;
   FORM_DISPLAY_ENGINE_STATEMENT *Statement;
 
@@ -394,9 +394,9 @@ GetWidth (
   // See if the second text parameter is really NULL
   //
   if (Statement->OpCode->OpCode == EFI_IFR_TEXT_OP) {
-    TestOp = (EFI_IFR_TEXT *) Statement->OpCode;
-    if (TestOp->TextTwo != 0) {
-      String = GetToken (TestOp->TextTwo, gFormData->HiiHandle);
+    TextOp = (EFI_IFR_TEXT *) Statement->OpCode;
+    if (TextOp->TextTwo != 0) {
+      String = GetToken (TextOp->TextTwo, gFormData->HiiHandle);
       Size   = StrLen (String);
       FreePool (String);
     }
@@ -2166,7 +2166,7 @@ HasOptionString (
   FORM_DISPLAY_ENGINE_STATEMENT   *Statement;
   CHAR16                          *String;
   UINTN                           Size;
-  EFI_IFR_TEXT                    *TestOp;
+  EFI_IFR_TEXT                    *TextOp;
 
   Size = 0;
   Statement = MenuOption->ThisTag;
@@ -2175,9 +2175,9 @@ HasOptionString (
   // See if the second text parameter is really NULL
   //
   if (Statement->OpCode->OpCode == EFI_IFR_TEXT_OP) {
-    TestOp = (EFI_IFR_TEXT *) Statement->OpCode;
-    if (TestOp->TextTwo != 0) {
-      String = GetToken (TestOp->TextTwo, gFormData->HiiHandle);
+    TextOp = (EFI_IFR_TEXT *) Statement->OpCode;
+    if (TextOp->TextTwo != 0) {
+      String = GetToken (TextOp->TextTwo, gFormData->HiiHandle);
       Size   = StrLen (String);
       FreePool (String);
     }
-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#66921): https://edk2.groups.io/g/devel/message/66921
Mute This Topic: https://groups.io/mt/78003643/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
回复: [edk2-devel] [PATCH] MdeModulePkg: Correct the variable name.
Posted by gaoliming 3 years, 5 months ago 
Chao:
  Please update the commit message title as MdeModulePkg DisplayEngineDxe:
Correct the local variable name
  
  With this change, Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+66921+4905953+8761045@groups.io
> <bounce+27952+66921+4905953+8761045@groups.io> 代表
> gechao@greatwall.com.cn
> 发送时间: 2020年11月3日 10:01
> 收件人: devel@edk2.groups.io
> 抄送: dandan.bi@intel.com; eric.dong@intel.com; gechao
> <gechao@greatwall.com.cn>
> 主题: [edk2-devel] [PATCH] MdeModulePkg: Correct the variable name.
> 
> From: gechao <gechao@greatwall.com.cn>
> 
> Signed-off-by: gechao <gechao@greatwall.com.cn>
> ---
>  .../Universal/DisplayEngineDxe/FormDisplay.c     | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c
> b/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c
> index 3b034a1c82..a3898dc2ec 100644
> --- a/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c
> +++ b/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c
> @@ -372,7 +372,7 @@ GetWidth (
>  {
> 
>    CHAR16                        *String;
> 
>    UINTN                         Size;
> 
> -  EFI_IFR_TEXT                  *TestOp;
> 
> +  EFI_IFR_TEXT                  *TextOp;
> 
>    UINT16                        ReturnWidth;
> 
>    FORM_DISPLAY_ENGINE_STATEMENT *Statement;
> 
> 
> 
> @@ -394,9 +394,9 @@ GetWidth (
>    // See if the second text parameter is really NULL
> 
>    //
> 
>    if (Statement->OpCode->OpCode == EFI_IFR_TEXT_OP) {
> 
> -    TestOp = (EFI_IFR_TEXT *) Statement->OpCode;
> 
> -    if (TestOp->TextTwo != 0) {
> 
> -      String = GetToken (TestOp->TextTwo, gFormData->HiiHandle);
> 
> +    TextOp = (EFI_IFR_TEXT *) Statement->OpCode;
> 
> +    if (TextOp->TextTwo != 0) {
> 
> +      String = GetToken (TextOp->TextTwo, gFormData->HiiHandle);
> 
>        Size   = StrLen (String);
> 
>        FreePool (String);
> 
>      }
> 
> @@ -2166,7 +2166,7 @@ HasOptionString (
>    FORM_DISPLAY_ENGINE_STATEMENT   *Statement;
> 
>    CHAR16                          *String;
> 
>    UINTN                           Size;
> 
> -  EFI_IFR_TEXT                    *TestOp;
> 
> +  EFI_IFR_TEXT                    *TextOp;
> 
> 
> 
>    Size = 0;
> 
>    Statement = MenuOption->ThisTag;
> 
> @@ -2175,9 +2175,9 @@ HasOptionString (
>    // See if the second text parameter is really NULL
> 
>    //
> 
>    if (Statement->OpCode->OpCode == EFI_IFR_TEXT_OP) {
> 
> -    TestOp = (EFI_IFR_TEXT *) Statement->OpCode;
> 
> -    if (TestOp->TextTwo != 0) {
> 
> -      String = GetToken (TestOp->TextTwo, gFormData->HiiHandle);
> 
> +    TextOp = (EFI_IFR_TEXT *) Statement->OpCode;
> 
> +    if (TextOp->TextTwo != 0) {
> 
> +      String = GetToken (TextOp->TextTwo, gFormData->HiiHandle);
> 
>        Size   = StrLen (String);
> 
>        FreePool (String);
> 
>      }
> 
> --
> 2.25.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#66921): https://edk2.groups.io/g/devel/message/66921
> Mute This Topic: https://groups.io/mt/78003643/4905953
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaoliming@byosoft.com.cn]
> -=-=-=-=-=-=
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67204): https://edk2.groups.io/g/devel/message/67204
Mute This Topic: https://groups.io/mt/78151298/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.