BaseTools/Source/Python/Workspace/DscBuildData.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Fix a Edk2Logger.warn() message format to match the arguments.
We ran into this after a failure in PcdValueInit. The failure was
masked by a new exception, "TypeError: not all arguments converted
during string formatting".
Signed-off-by: Jake Garver <jake@nvidia.com>
---
BaseTools/Source/Python/Workspace/DscBuildData.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTools/Source/Python/Workspace/DscBuildData.py
index 35ec5b37ff..d29b9bf13d 100644
--- a/BaseTools/Source/Python/Workspace/DscBuildData.py
+++ b/BaseTools/Source/Python/Workspace/DscBuildData.py
@@ -3033,7 +3033,7 @@ class DscBuildData(PlatformBuildClassObject):
returncode, StdOut, StdErr = DscBuildData.ExecuteCommand (Command)
EdkLogger.verbose ('%s\n%s\n%s' % (Command, StdOut, StdErr))
if returncode != 0:
- EdkLogger.warn('Build', COMMAND_FAILURE, 'Can not collect output from command: %s\n%s\n' % (Command, StdOut, StdErr))
+ EdkLogger.warn('Build', COMMAND_FAILURE, 'Can not collect output from command: %s\n%s\n%s\n' % (Command, StdOut, StdErr))
#start update structure pcd final value
File = open (OutputValueFile, 'r')
--
2.17.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#85882): https://edk2.groups.io/g/devel/message/85882
Mute This Topic: https://groups.io/mt/88573504/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn> > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Jake Garver > via groups.io > 发送时间: 2022年1月21日 7:58 > 收件人: devel@edk2.groups.io; jbrasen@nvidia.com; > ashishsingha@nvidia.com > 抄送: Jake Garver <jake@nvidia.com> > 主题: [edk2-devel] [PATCH] BaseTools: Fix error leg in DscBuildData.py > > Fix a Edk2Logger.warn() message format to match the arguments. > > We ran into this after a failure in PcdValueInit. The failure was > masked by a new exception, "TypeError: not all arguments converted > during string formatting". > > Signed-off-by: Jake Garver <jake@nvidia.com> > --- > BaseTools/Source/Python/Workspace/DscBuildData.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py > b/BaseTools/Source/Python/Workspace/DscBuildData.py > index 35ec5b37ff..d29b9bf13d 100644 > --- a/BaseTools/Source/Python/Workspace/DscBuildData.py > +++ b/BaseTools/Source/Python/Workspace/DscBuildData.py > @@ -3033,7 +3033,7 @@ class DscBuildData(PlatformBuildClassObject): > returncode, StdOut, StdErr = DscBuildData.ExecuteCommand > (Command) > EdkLogger.verbose ('%s\n%s\n%s' % (Command, StdOut, > StdErr)) > if returncode != 0: > - EdkLogger.warn('Build', COMMAND_FAILURE, 'Can not > collect output from command: %s\n%s\n' % (Command, StdOut, StdErr)) > + EdkLogger.warn('Build', COMMAND_FAILURE, 'Can not > collect output from command: %s\n%s\n%s\n' % (Command, StdOut, StdErr)) > > #start update structure pcd final value > File = open (OutputValueFile, 'r') > -- > 2.17.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86098): https://edk2.groups.io/g/devel/message/86098 Mute This Topic: https://groups.io/mt/88712286/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Hi folks, Any interest in accepting this simple fix? Thanks, Jake -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86654): https://edk2.groups.io/g/devel/message/86654 Mute This Topic: https://groups.io/mt/88573504/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
It has been merged at d4ac53aa91b8a3602166c6adcb9ba8678e0ae969 Thanks Liming 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Jake Garver via groups.io 发送时间: 2022年2月14日 21:10 收件人: Jake Garver <jake@nvidia.com>; devel@edk2.groups.io 主题: Re: [edk2-devel] [PATCH] BaseTools: Fix error leg in DscBuildData.py Hi folks, Any interest in accepting this simple fix? Thanks, Jake -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86669): https://edk2.groups.io/g/devel/message/86669 Mute This Topic: https://groups.io/mt/89155382/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.