[edk2-devel] [PATCH 0/2] SEV-SNP guest support fixes

Lendacky, Thomas via groups.io posted 2 patches 1 year, 8 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
UefiCpuPkg/Library/MpInitLib/X64/AmdSev.c | 224 ++++++++++++++--------
1 file changed, 144 insertions(+), 80 deletions(-)
[edk2-devel] [PATCH 0/2] SEV-SNP guest support fixes
Posted by Lendacky, Thomas via groups.io 1 year, 8 months ago
This patch series provides some fixes around AP creation:

- An erratum on AMD hardware requires that a VMSA not be aligned on a
  2MB boundary. To work around this issue, allocate 2 pages of memory
  and using the page that is not 2MB aligned and freeing the other.

- When parking APs after exiting boot services, the current SNP support
  will perform an allocation that will not be reflected in memory map
  being supplied to the OS. Instead of allocating new VMSAs each time,
  re-use the current VMSA.

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4353

---

These patches are based on commit:
f80f052277c8 ("OvmfPkg/RiscVVirt: Add Stack HOB")

Cc:	Eric Dong <eric.dong@intel.com>
Cc:	Ray Ni <ray.ni@intel.com>
Cc:	Rahul Kumar <rahul1.kumar@intel.com>
Cc:	Gerd Hoffmann <kraxel@redhat.com>
Cc:	Michael Roth <michael.roth@amd.com>
Cc:	Ashish Kalra <Ashish.Kalra@amd.com>

Tom Lendacky (2):
  UefiCpuPkg/MpInitLib: Ensure SEV-SNP VMSA allocations are not 2MB
    aligned
  UefiCpuPkg/MpInitLib: Reuse VMSA allocation to avoid unreserved
    allocation

 UefiCpuPkg/Library/MpInitLib/X64/AmdSev.c | 224 ++++++++++++++--------
 1 file changed, 144 insertions(+), 80 deletions(-)

-- 
2.39.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101007): https://edk2.groups.io/g/devel/message/101007
Mute This Topic: https://groups.io/mt/97524216/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 0/2] SEV-SNP guest support fixes
Posted by Lendacky, Thomas via groups.io 1 year, 8 months ago
On 3/10/23 11:03, Tom Lendacky wrote:
> This patch series provides some fixes around AP creation:
> 
> - An erratum on AMD hardware requires that a VMSA not be aligned on a
>    2MB boundary. To work around this issue, allocate 2 pages of memory
>    and using the page that is not 2MB aligned and freeing the other.
> 
> - When parking APs after exiting boot services, the current SNP support
>    will perform an allocation that will not be reflected in memory map
>    being supplied to the OS. Instead of allocating new VMSAs each time,
>    re-use the current VMSA.
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4353
> 
> ---
> 
> These patches are based on commit:
> f80f052277c8 ("OvmfPkg/RiscVVirt: Add Stack HOB")

Specified the wrong commit here...  should be:

9b94ebb0c826 ("DynamicTablesPkg: Add SMBIOS String table helper library")

Also, the first patch has a #define for IS_ALIGNED, which Gerd is trying 
to address with another patch series. Once his series is merged, I'll 
re-submit with the removal of the #define, but wanted to get this out for 
review now.

Thanks,
Tom

> 
> Cc:	Eric Dong <eric.dong@intel.com>
> Cc:	Ray Ni <ray.ni@intel.com>
> Cc:	Rahul Kumar <rahul1.kumar@intel.com>
> Cc:	Gerd Hoffmann <kraxel@redhat.com>
> Cc:	Michael Roth <michael.roth@amd.com>
> Cc:	Ashish Kalra <Ashish.Kalra@amd.com>
> 
> Tom Lendacky (2):
>    UefiCpuPkg/MpInitLib: Ensure SEV-SNP VMSA allocations are not 2MB
>      aligned
>    UefiCpuPkg/MpInitLib: Reuse VMSA allocation to avoid unreserved
>      allocation
> 
>   UefiCpuPkg/Library/MpInitLib/X64/AmdSev.c | 224 ++++++++++++++--------
>   1 file changed, 144 insertions(+), 80 deletions(-)
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101014): https://edk2.groups.io/g/devel/message/101014
Mute This Topic: https://groups.io/mt/97524216/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-