[AMD Official Use Only - General]
Hi Abdul,
Thanks for contributing this and addressing the comments. Please just add the review tag to each commit message and send out the V4. So maintainers know AMD has agreed with this change. We still need maintainers to review this patch set and merge it if they have no problem with it.
Thanks
Abner
> -----Original Message-----
> From: Abdul Lateef Attar <abdattar@amd.com>
> Sent: Thursday, January 19, 2023 1:01 AM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>;
> Grimes, Paul <Paul.Grimes@amd.com>; Kirkendall, Garrett
> <Garrett.Kirkendall@amd.com>; Chang, Abner <Abner.Chang@amd.com>;
> Eric Dong <eric.dong@intel.com>; Ray Ni <ray.ni@intel.com>; Rahul Kumar
> <rahul1.kumar@intel.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Zhiguang Liu <zhiguang.liu@intel.com>
> Subject: [PATCH v3 0/6] Adds AmdSmmCpuFeaturesLib for AMD Family
>
> V3 delta changes:
> Addressed review comments from Abner Chang.
>
> PR: https://github.com/tianocore/edk2/pull/3925
>
> Cc: Paul Grimes <paul.grimes@amd.com>
> Cc: Garrett Kirkendall <garrett.kirkendall@amd.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
>
> Abdul Lateef Attar (6):
> MdePkg: Adds AMD SMRAM save state map
> UefiCpuPkg: Adds SmmSmramSaveStateLib library class
> UefiCpuPkg: Implements SmmSmramSaveStateLib library class
> UefiCpuPkg/SmmCpuFeaturesLib: Restructure arch-dependent code
> UefiCpuPkg: Initial implementation of AMD's SmmCpuFeaturesLib
> UefiCpuPkg: Implements SmmCpuFeaturesLib for AMD Family
>
> UefiCpuPkg/UefiCpuPkg.dec | 4 +
> UefiCpuPkg/UefiCpuPkg.dsc | 11 +
> .../AmdSmmCpuFeaturesLib.inf | 39 ++
> .../AmdSmmSmramSaveStateLib.inf | 28 ++
> .../Include/Register/Amd/SmramSaveStateMap.h | 194 ++++++++
> .../Include/Library/SmmSmramSaveStateLib.h | 70 +++
> .../SmmSmramSaveStateLib/SmramSaveState.h | 102 ++++
> .../SmmCpuFeaturesLib/AmdSmmCpuFeaturesLib.c | 445
> ++++++++++++++++++
> .../IntelSmmCpuFeaturesLib.c | 128 +++++
> .../SmmCpuFeaturesLibCommon.c | 128 -----
> .../SmmSmramSaveStateLib/AmdSmramSaveState.c | 319 +++++++++++++
> .../SmramSaveStateCommon.c | 124 +++++
> MdePkg/MdePkg.ci.yaml | 4 +-
> 13 files changed, 1467 insertions(+), 129 deletions(-) create mode 100644
> UefiCpuPkg/Library/SmmCpuFeaturesLib/AmdSmmCpuFeaturesLib.inf
> create mode 100644
> UefiCpuPkg/Library/SmmSmramSaveStateLib/AmdSmmSmramSaveStateLib.
> inf
> create mode 100644
> MdePkg/Include/Register/Amd/SmramSaveStateMap.h
> create mode 100644 UefiCpuPkg/Include/Library/SmmSmramSaveStateLib.h
> create mode 100644
> UefiCpuPkg/Library/SmmSmramSaveStateLib/SmramSaveState.h
> create mode 100644
> UefiCpuPkg/Library/SmmCpuFeaturesLib/AmdSmmCpuFeaturesLib.c
> create mode 100644
> UefiCpuPkg/Library/SmmSmramSaveStateLib/AmdSmramSaveState.c
> create mode 100644
> UefiCpuPkg/Library/SmmSmramSaveStateLib/SmramSaveStateCommon.c
>
> --
> 2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98864): https://edk2.groups.io/g/devel/message/98864
Mute This Topic: https://groups.io/mt/96358344/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-