[v2] DynamicTablesPkg: Pcie generation updates

[edk2-devel] [PATCH v2 0/4] DynamicTablesPkg: Pcie generation updates

Posted by Jeff Brasen via groups.io 1 year, 10 months ago

Add fixes/features to dynamic PCIe support

- Correct issue with translation in generated ACPI tables.
- Allow for more than 16 controllers to be generated.
- Allow optional use of segment number as UID for cases where ACPI path is needed in other places.
- Add support for override protocol that allows platform specific modification of node prior to creation.

Update:
v2 - Add IsPosDecode logic to translation patch

Jeff Brasen (4):
  DynamicTablesPkg: AcpiSsdtPcieLibArm: Correct translation value
  DynamicTablesPkg: AcpiSsdtPcieLibArm: Allow use of segment number as
    UID
  DynamicTablesPkg: AcpiSsdtPcieLibArm: Support UID > 0xF
  DynamicTablesPkg: AcpiSsdtPcieLibArm: Add support for override
    protocol

 DynamicTablesPkg/DynamicTablesPkg.dec         |  6 ++
 .../Protocol/SsdtPcieOverrideProtocol.h       | 63 ++++++++++++++++
 .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.c    | 73 ++++++++++++++++---
 .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.h    |  2 +-
 .../Arm/AcpiSsdtPcieLibArm/SsdtPcieLibArm.inf |  7 ++
 5 files changed, 139 insertions(+), 12 deletions(-)
 create mode 100644 DynamicTablesPkg/Include/Protocol/SsdtPcieOverrideProtocol.h

-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90997): https://edk2.groups.io/g/devel/message/90997
Mute This Topic: https://groups.io/mt/92113674/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/4] DynamicTablesPkg: Pcie generation updates

Posted by Jeff Brasen via groups.io 1 year, 10 months ago

Pierre,

 Any thoughts on this v2 version?

-Jeff


> -----Original Message-----
> From: Jeff Brasen <jbrasen@nvidia.com>
> Sent: Friday, July 1, 2022 10:33 AM
> To: devel@edk2.groups.io
> Cc: Pierre.Gondois@arm.com; Sami.Mujawar@arm.com;
> Alexei.Fedorov@arm.com; Jeff Brasen <jbrasen@nvidia.com>
> Subject: [PATCH v2 0/4] DynamicTablesPkg: Pcie generation updates
> 
> Add fixes/features to dynamic PCIe support
> 
> - Correct issue with translation in generated ACPI tables.
> - Allow for more than 16 controllers to be generated.
> - Allow optional use of segment number as UID for cases where ACPI path is
> needed in other places.
> - Add support for override protocol that allows platform specific modification
> of node prior to creation.
> 
> Update:
> v2 - Add IsPosDecode logic to translation patch
> 
> Jeff Brasen (4):
>   DynamicTablesPkg: AcpiSsdtPcieLibArm: Correct translation value
>   DynamicTablesPkg: AcpiSsdtPcieLibArm: Allow use of segment number as
>     UID
>   DynamicTablesPkg: AcpiSsdtPcieLibArm: Support UID > 0xF
>   DynamicTablesPkg: AcpiSsdtPcieLibArm: Add support for override
>     protocol
> 
>  DynamicTablesPkg/DynamicTablesPkg.dec         |  6 ++
>  .../Protocol/SsdtPcieOverrideProtocol.h       | 63 ++++++++++++++++
>  .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.c    | 73 ++++++++++++++++---
>  .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.h    |  2 +-
>  .../Arm/AcpiSsdtPcieLibArm/SsdtPcieLibArm.inf |  7 ++
>  5 files changed, 139 insertions(+), 12 deletions(-)  create mode 100644
> DynamicTablesPkg/Include/Protocol/SsdtPcieOverrideProtocol.h
> 
> --
> 2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91146): https://edk2.groups.io/g/devel/message/91146
Mute This Topic: https://groups.io/mt/92113674/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/4] DynamicTablesPkg: Pcie generation updates

Posted by PierreGondois 1 year, 9 months ago

Hello Jeff,
I had some questions about the V1 at:
https://edk2.groups.io/g/devel/topic/92089320#90932
https://edk2.groups.io/g/devel/topic/92089321#90933

Regards,
Pierre

On 7/7/22 18:59, Jeff Brasen wrote:
> Pierre,
> 
>   Any thoughts on this v2 version?
> 
> -Jeff
> 
> 
>> -----Original Message-----
>> From: Jeff Brasen <jbrasen@nvidia.com>
>> Sent: Friday, July 1, 2022 10:33 AM
>> To: devel@edk2.groups.io
>> Cc: Pierre.Gondois@arm.com; Sami.Mujawar@arm.com;
>> Alexei.Fedorov@arm.com; Jeff Brasen <jbrasen@nvidia.com>
>> Subject: [PATCH v2 0/4] DynamicTablesPkg: Pcie generation updates
>>
>> Add fixes/features to dynamic PCIe support
>>
>> - Correct issue with translation in generated ACPI tables.
>> - Allow for more than 16 controllers to be generated.
>> - Allow optional use of segment number as UID for cases where ACPI path is
>> needed in other places.
>> - Add support for override protocol that allows platform specific modification
>> of node prior to creation.
>>
>> Update:
>> v2 - Add IsPosDecode logic to translation patch
>>
>> Jeff Brasen (4):
>>    DynamicTablesPkg: AcpiSsdtPcieLibArm: Correct translation value
>>    DynamicTablesPkg: AcpiSsdtPcieLibArm: Allow use of segment number as
>>      UID
>>    DynamicTablesPkg: AcpiSsdtPcieLibArm: Support UID > 0xF
>>    DynamicTablesPkg: AcpiSsdtPcieLibArm: Add support for override
>>      protocol
>>
>>   DynamicTablesPkg/DynamicTablesPkg.dec         |  6 ++
>>   .../Protocol/SsdtPcieOverrideProtocol.h       | 63 ++++++++++++++++
>>   .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.c    | 73 ++++++++++++++++---
>>   .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.h    |  2 +-
>>   .../Arm/AcpiSsdtPcieLibArm/SsdtPcieLibArm.inf |  7 ++
>>   5 files changed, 139 insertions(+), 12 deletions(-)  create mode 100644
>> DynamicTablesPkg/Include/Protocol/SsdtPcieOverrideProtocol.h
>>
>> --
>> 2.25.1
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91177): https://edk2.groups.io/g/devel/message/91177
Mute This Topic: https://groups.io/mt/92113674/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/4] DynamicTablesPkg: Pcie generation updates

Posted by Jeff Brasen via groups.io 1 year, 9 months ago

Ok, I never got those responses, will have to check what happened with my email. Will respond to those.

> -----Original Message-----
> From: Pierre Gondois <pierre.gondois@arm.com>
> Sent: Friday, July 8, 2022 1:31 AM
> To: Jeff Brasen <jbrasen@nvidia.com>; devel@edk2.groups.io
> Cc: Sami.Mujawar@arm.com; Alexei.Fedorov@arm.com
> Subject: Re: [PATCH v2 0/4] DynamicTablesPkg: Pcie generation updates
> 
> External email: Use caution opening links or attachments
> 
> 
> Hello Jeff,
> I had some questions about the V1 at:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk
> 2.groups.io%2Fg%2Fdevel%2Ftopic%2F92089320%2390932&amp;data=05%7
> C01%7Cjbrasen%40nvidia.com%7C8a911ded72fd403690f208da60b3e0a9%7C
> 43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637928622942274065%7C
> Unknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJB
> TiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=p3jCMX%
> 2Fi0wf60FA2DgsGV7b3Vq6qw8jP6Kjp82YOoKg%3D&amp;reserved=0
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk
> 2.groups.io%2Fg%2Fdevel%2Ftopic%2F92089321%2390933&amp;data=05%7
> C01%7Cjbrasen%40nvidia.com%7C8a911ded72fd403690f208da60b3e0a9%7C
> 43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637928622942274065%7C
> Unknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJB
> TiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=IBjcEWb5
> VY7iXXkwOuP5LZN8c3aFdB25ophGXAVfHjQ%3D&amp;reserved=0
> 
> Regards,
> Pierre
> 
> On 7/7/22 18:59, Jeff Brasen wrote:
> > Pierre,
> >
> >   Any thoughts on this v2 version?
> >
> > -Jeff
> >
> >
> >> -----Original Message-----
> >> From: Jeff Brasen <jbrasen@nvidia.com>
> >> Sent: Friday, July 1, 2022 10:33 AM
> >> To: devel@edk2.groups.io
> >> Cc: Pierre.Gondois@arm.com; Sami.Mujawar@arm.com;
> >> Alexei.Fedorov@arm.com; Jeff Brasen <jbrasen@nvidia.com>
> >> Subject: [PATCH v2 0/4] DynamicTablesPkg: Pcie generation updates
> >>
> >> Add fixes/features to dynamic PCIe support
> >>
> >> - Correct issue with translation in generated ACPI tables.
> >> - Allow for more than 16 controllers to be generated.
> >> - Allow optional use of segment number as UID for cases where ACPI
> >> path is needed in other places.
> >> - Add support for override protocol that allows platform specific
> >> modification of node prior to creation.
> >>
> >> Update:
> >> v2 - Add IsPosDecode logic to translation patch
> >>
> >> Jeff Brasen (4):
> >>    DynamicTablesPkg: AcpiSsdtPcieLibArm: Correct translation value
> >>    DynamicTablesPkg: AcpiSsdtPcieLibArm: Allow use of segment number
> as
> >>      UID
> >>    DynamicTablesPkg: AcpiSsdtPcieLibArm: Support UID > 0xF
> >>    DynamicTablesPkg: AcpiSsdtPcieLibArm: Add support for override
> >>      protocol
> >>
> >>   DynamicTablesPkg/DynamicTablesPkg.dec         |  6 ++
> >>   .../Protocol/SsdtPcieOverrideProtocol.h       | 63 ++++++++++++++++
> >>   .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.c    | 73 ++++++++++++++++-
> --
> >>   .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.h    |  2 +-
> >>   .../Arm/AcpiSsdtPcieLibArm/SsdtPcieLibArm.inf |  7 ++
> >>   5 files changed, 139 insertions(+), 12 deletions(-)  create mode
> >> 100644 DynamicTablesPkg/Include/Protocol/SsdtPcieOverrideProtocol.h
> >>
> >> --
> >> 2.25.1
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91183): https://edk2.groups.io/g/devel/message/91183
Mute This Topic: https://groups.io/mt/92113674/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-