[edk2-devel] [PATCH V4 0/5] CryptoPkg/openssl: Enable EC conditionally.

yi1 li posted 5 patches 1 week, 6 days ago
Failed in applying to current master (apply log)
CryptoPkg/CryptoPkg.ci.yaml                   |  14 +-
CryptoPkg/CryptoPkg.dec                       |   2 +-
.../Library/BaseCryptLib/BaseCryptLib.inf     |   2 +-
.../Library/BaseCryptLib/PeiCryptLib.inf      |   2 +-
.../Library/BaseCryptLib/RuntimeCryptLib.inf  |   2 +-
.../Library/BaseCryptLib/SmmCryptLib.inf      |   2 +-
.../BaseCryptLib/UnitTestHostBaseCryptLib.inf |   2 +-
CryptoPkg/Library/Include/crypto/dso_conf.h   |   7 +-
.../Library/Include/openssl/opensslconf.h     | 348 +-----------------
.../Include/openssl/opensslconf_generated.h   | 333 +++++++++++++++++
CryptoPkg/Library/OpensslLib/OpensslLib.inf   |  98 ++---
.../Library/OpensslLib/OpensslLibCrypto.inf   |  98 ++---
CryptoPkg/Library/OpensslLib/process_files.pl |  77 +++-
CryptoPkg/Library/TlsLib/TlsLib.inf           |   2 +-
14 files changed, 552 insertions(+), 437 deletions(-)
create mode 100644 CryptoPkg/Library/Include/openssl/opensslconf_generated.h
[edk2-devel] [PATCH V4 0/5] CryptoPkg/openssl: Enable EC conditionally.
Posted by yi1 li 1 week, 6 days ago
Recommend from Gerd:
(2) Keep the EC config option, but update process_files.pl to
  automatically add the PcdEcEnabled config option handling
  to the files it generates.

This patch set does (2).

When remove 'no-ec' from openssl configure list, will automatically remove 'OPENSSL_NO_EC', 'OPENSSL_NO_ECDH', 'OPENSSL_NO_ECDSA', 'OPENSSL_NO_TLS1_3', 'OPENSSL_NO_SM2' from header, and add '/ec/.', '/sm2/.' files to INF files.

Signed-off-by: Yi Li <yi1.li@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
Cc: Guomin Jiang <guomin.jiang@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>

Yi Li (5):
  CryptoPkg: Rename PCD about openssl EC configuration
  CryptoPkg: Separate auto-generated openssl config and edk2 openssl
    config
  CryptoPkg: Update process_files.pl to automatically add PCD config
    option
  CryptoPkg/openssl: update generated files
  CryptoPkg/openssl: disable codestyle checks for generated files

 CryptoPkg/CryptoPkg.ci.yaml                   |  14 +-
 CryptoPkg/CryptoPkg.dec                       |   2 +-
 .../Library/BaseCryptLib/BaseCryptLib.inf     |   2 +-
 .../Library/BaseCryptLib/PeiCryptLib.inf      |   2 +-
 .../Library/BaseCryptLib/RuntimeCryptLib.inf  |   2 +-
 .../Library/BaseCryptLib/SmmCryptLib.inf      |   2 +-
 .../BaseCryptLib/UnitTestHostBaseCryptLib.inf |   2 +-
 CryptoPkg/Library/Include/crypto/dso_conf.h   |   7 +-
 .../Library/Include/openssl/opensslconf.h     | 348 +-----------------
 .../Include/openssl/opensslconf_generated.h   | 333 +++++++++++++++++
 CryptoPkg/Library/OpensslLib/OpensslLib.inf   |  98 ++---
 .../Library/OpensslLib/OpensslLibCrypto.inf   |  98 ++---
 CryptoPkg/Library/OpensslLib/process_files.pl |  77 +++-
 CryptoPkg/Library/TlsLib/TlsLib.inf           |   2 +-
 14 files changed, 552 insertions(+), 437 deletions(-)
 create mode 100644 CryptoPkg/Library/Include/openssl/opensslconf_generated.h

-- 
2.31.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89640): https://edk2.groups.io/g/devel/message/89640
Mute This Topic: https://groups.io/mt/91007892/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH V4 0/5] CryptoPkg/openssl: Enable EC conditionally.
Posted by Yao, Jiewen 1 week, 5 days ago
Merged https://github.com/tianocore/edk2/pull/2871


> -----Original Message-----
> From: Li, Yi1 <yi1.li@intel.com>
> Sent: Tuesday, May 10, 2022 3:19 PM
> To: devel@edk2.groups.io
> Cc: Li, Yi1 <yi1.li@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian
> J <jian.j.wang@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang, Guomin
> <guomin.jiang@intel.com>; Gerd Hoffmann <kraxel@redhat.com>
> Subject: [PATCH V4 0/5] CryptoPkg/openssl: Enable EC conditionally.
> 
> Recommend from Gerd:
> (2) Keep the EC config option, but update process_files.pl to
>   automatically add the PcdEcEnabled config option handling
>   to the files it generates.
> 
> This patch set does (2).
> 
> When remove 'no-ec' from openssl configure list, will automatically remove
> 'OPENSSL_NO_EC', 'OPENSSL_NO_ECDH', 'OPENSSL_NO_ECDSA',
> 'OPENSSL_NO_TLS1_3', 'OPENSSL_NO_SM2' from header, and add '/ec/.',
> '/sm2/.' files to INF files.
> 
> Signed-off-by: Yi Li <yi1.li@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> 
> Yi Li (5):
>   CryptoPkg: Rename PCD about openssl EC configuration
>   CryptoPkg: Separate auto-generated openssl config and edk2 openssl
>     config
>   CryptoPkg: Update process_files.pl to automatically add PCD config
>     option
>   CryptoPkg/openssl: update generated files
>   CryptoPkg/openssl: disable codestyle checks for generated files
> 
>  CryptoPkg/CryptoPkg.ci.yaml                   |  14 +-
>  CryptoPkg/CryptoPkg.dec                       |   2 +-
>  .../Library/BaseCryptLib/BaseCryptLib.inf     |   2 +-
>  .../Library/BaseCryptLib/PeiCryptLib.inf      |   2 +-
>  .../Library/BaseCryptLib/RuntimeCryptLib.inf  |   2 +-
>  .../Library/BaseCryptLib/SmmCryptLib.inf      |   2 +-
>  .../BaseCryptLib/UnitTestHostBaseCryptLib.inf |   2 +-
>  CryptoPkg/Library/Include/crypto/dso_conf.h   |   7 +-
>  .../Library/Include/openssl/opensslconf.h     | 348 +-----------------
>  .../Include/openssl/opensslconf_generated.h   | 333 +++++++++++++++++
>  CryptoPkg/Library/OpensslLib/OpensslLib.inf   |  98 ++---
>  .../Library/OpensslLib/OpensslLibCrypto.inf   |  98 ++---
>  CryptoPkg/Library/OpensslLib/process_files.pl |  77 +++-
>  CryptoPkg/Library/TlsLib/TlsLib.inf           |   2 +-
>  14 files changed, 552 insertions(+), 437 deletions(-)
>  create mode 100644
> CryptoPkg/Library/Include/openssl/opensslconf_generated.h
> 
> --
> 2.31.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89678): https://edk2.groups.io/g/devel/message/89678
Mute This Topic: https://groups.io/mt/91007892/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH V4 0/5] CryptoPkg/openssl: Enable EC conditionally.
Posted by Yao, Jiewen 1 week, 5 days ago
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>


> -----Original Message-----
> From: Li, Yi1 <yi1.li@intel.com>
> Sent: Tuesday, May 10, 2022 3:19 PM
> To: devel@edk2.groups.io
> Cc: Li, Yi1 <yi1.li@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian
> J <jian.j.wang@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang, Guomin
> <guomin.jiang@intel.com>; Gerd Hoffmann <kraxel@redhat.com>
> Subject: [PATCH V4 0/5] CryptoPkg/openssl: Enable EC conditionally.
> 
> Recommend from Gerd:
> (2) Keep the EC config option, but update process_files.pl to
>   automatically add the PcdEcEnabled config option handling
>   to the files it generates.
> 
> This patch set does (2).
> 
> When remove 'no-ec' from openssl configure list, will automatically remove
> 'OPENSSL_NO_EC', 'OPENSSL_NO_ECDH', 'OPENSSL_NO_ECDSA',
> 'OPENSSL_NO_TLS1_3', 'OPENSSL_NO_SM2' from header, and add '/ec/.',
> '/sm2/.' files to INF files.
> 
> Signed-off-by: Yi Li <yi1.li@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> 
> Yi Li (5):
>   CryptoPkg: Rename PCD about openssl EC configuration
>   CryptoPkg: Separate auto-generated openssl config and edk2 openssl
>     config
>   CryptoPkg: Update process_files.pl to automatically add PCD config
>     option
>   CryptoPkg/openssl: update generated files
>   CryptoPkg/openssl: disable codestyle checks for generated files
> 
>  CryptoPkg/CryptoPkg.ci.yaml                   |  14 +-
>  CryptoPkg/CryptoPkg.dec                       |   2 +-
>  .../Library/BaseCryptLib/BaseCryptLib.inf     |   2 +-
>  .../Library/BaseCryptLib/PeiCryptLib.inf      |   2 +-
>  .../Library/BaseCryptLib/RuntimeCryptLib.inf  |   2 +-
>  .../Library/BaseCryptLib/SmmCryptLib.inf      |   2 +-
>  .../BaseCryptLib/UnitTestHostBaseCryptLib.inf |   2 +-
>  CryptoPkg/Library/Include/crypto/dso_conf.h   |   7 +-
>  .../Library/Include/openssl/opensslconf.h     | 348 +-----------------
>  .../Include/openssl/opensslconf_generated.h   | 333 +++++++++++++++++
>  CryptoPkg/Library/OpensslLib/OpensslLib.inf   |  98 ++---
>  .../Library/OpensslLib/OpensslLibCrypto.inf   |  98 ++---
>  CryptoPkg/Library/OpensslLib/process_files.pl |  77 +++-
>  CryptoPkg/Library/TlsLib/TlsLib.inf           |   2 +-
>  14 files changed, 552 insertions(+), 437 deletions(-)
>  create mode 100644
> CryptoPkg/Library/Include/openssl/opensslconf_generated.h
> 
> --
> 2.31.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89677): https://edk2.groups.io/g/devel/message/89677
Mute This Topic: https://groups.io/mt/91007892/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH V4 0/5] CryptoPkg/openssl: Enable EC conditionally.
Posted by Yao, Jiewen 1 week, 6 days ago
Series reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>

> -----Original Message-----
> From: Li, Yi1 <yi1.li@intel.com>
> Sent: Tuesday, May 10, 2022 3:19 PM
> To: devel@edk2.groups.io
> Cc: Li, Yi1 <yi1.li@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian
> J <jian.j.wang@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang, Guomin
> <guomin.jiang@intel.com>; Gerd Hoffmann <kraxel@redhat.com>
> Subject: [PATCH V4 0/5] CryptoPkg/openssl: Enable EC conditionally.
> 
> Recommend from Gerd:
> (2) Keep the EC config option, but update process_files.pl to
>   automatically add the PcdEcEnabled config option handling
>   to the files it generates.
> 
> This patch set does (2).
> 
> When remove 'no-ec' from openssl configure list, will automatically remove
> 'OPENSSL_NO_EC', 'OPENSSL_NO_ECDH', 'OPENSSL_NO_ECDSA',
> 'OPENSSL_NO_TLS1_3', 'OPENSSL_NO_SM2' from header, and add '/ec/.',
> '/sm2/.' files to INF files.
> 
> Signed-off-by: Yi Li <yi1.li@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> 
> Yi Li (5):
>   CryptoPkg: Rename PCD about openssl EC configuration
>   CryptoPkg: Separate auto-generated openssl config and edk2 openssl
>     config
>   CryptoPkg: Update process_files.pl to automatically add PCD config
>     option
>   CryptoPkg/openssl: update generated files
>   CryptoPkg/openssl: disable codestyle checks for generated files
> 
>  CryptoPkg/CryptoPkg.ci.yaml                   |  14 +-
>  CryptoPkg/CryptoPkg.dec                       |   2 +-
>  .../Library/BaseCryptLib/BaseCryptLib.inf     |   2 +-
>  .../Library/BaseCryptLib/PeiCryptLib.inf      |   2 +-
>  .../Library/BaseCryptLib/RuntimeCryptLib.inf  |   2 +-
>  .../Library/BaseCryptLib/SmmCryptLib.inf      |   2 +-
>  .../BaseCryptLib/UnitTestHostBaseCryptLib.inf |   2 +-
>  CryptoPkg/Library/Include/crypto/dso_conf.h   |   7 +-
>  .../Library/Include/openssl/opensslconf.h     | 348 +-----------------
>  .../Include/openssl/opensslconf_generated.h   | 333 +++++++++++++++++
>  CryptoPkg/Library/OpensslLib/OpensslLib.inf   |  98 ++---
>  .../Library/OpensslLib/OpensslLibCrypto.inf   |  98 ++---
>  CryptoPkg/Library/OpensslLib/process_files.pl |  77 +++-
>  CryptoPkg/Library/TlsLib/TlsLib.inf           |   2 +-
>  14 files changed, 552 insertions(+), 437 deletions(-)
>  create mode 100644
> CryptoPkg/Library/Include/openssl/opensslconf_generated.h
> 
> --
> 2.31.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89647): https://edk2.groups.io/g/devel/message/89647
Mute This Topic: https://groups.io/mt/91007892/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-