Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> -----Original Message-----
> From: Oram, Isaac W <isaac.w.oram@intel.com>
> Sent: Tuesday, January 11, 2022 6:20 PM
> To: devel@edk2.groups.io
> Cc: Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>
> Subject: [edk2-devel][edk2-platforms][PATCH V1 27/27]
> WhitleyOpenBoardPkg/Build: Enable Features/Intel features
>
> This enables Whitley as a test vehicle for features.
> These are not expected to be fully functional at this time.
> Specifically UserAuthentication causes a boot failure and the others have
> only been verified to be built and dispatched, not ported to the Whitley
> reference platform hardware.
>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
>
> Signed-off-by: Isaac Oram <isaac.w.oram@intel.com>
> ---
> Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc | 44
> ++++++++++++++++++++
> Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.fdf | 6 ++-
> 2 files changed, 49 insertions(+), 1 deletion(-)
>
> diff --git a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc
> b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc
> index f07b0a8ccf..42680254d1 100644
> --- a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc
> +++ b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc
> @@ -39,6 +39,50 @@
> DEFINE IIO_INSTANCE = UnknownCpu
> !endif
>
> +!include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
> +
> +[PcdsFixedAtBuild]
> +
> gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugPortLibInstance|1
> +
> +[PcdsFeatureFlag]
> + #
> + # Debugging features
> + #
> + gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugFeatureEnable
> |FALSE
> + gBeepDebugFeaturePkgTokenSpaceGuid.PcdBeepDebugFeatureEnable
> |FALSE
> +
> gPostCodeDebugFeaturePkgTokenSpaceGuid.PcdPostCodeDebugFeatureEn
> able |FALSE
> + gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugFeatureEnable
> |FALSE
> +
> + #
> + # Network features
> + #
> + gNetworkFeaturePkgTokenSpaceGuid.PcdNetworkFeatureEnable
> |FALSE
> +
> + #
> + # OutOfBandManagement features
> + #
> + gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable
> |FALSE
> + gSpcrFeaturePkgTokenSpaceGuid.PcdSpcrFeatureEnable
> |FALSE
> +
> + #
> + # PowerManagement features
> + #
> + gS3FeaturePkgTokenSpaceGuid.PcdS3FeatureEnable |FALSE
> +
> + #
> + # SystemInformation features
> + #
> + gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosFeatureEnable
> |FALSE
> +
> + #
> + # UserInterface features
> + #
> + gLogoFeaturePkgTokenSpaceGuid.PcdLogoFeatureEnable
> |FALSE
> +
> gUserAuthFeaturePkgTokenSpaceGuid.PcdUserAuthenticationFeatureEnabl
> e |FALSE
> +
> +
> gVirtualKeyboardFeaturePkgTokenSpaceGuid.PcdVirtualKeyboardFeatureEn
> ab
> + le |FALSE
> +
> +!include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
> +
> #
> # Platform On/Off features are defined here
> #
> diff --git a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.fdf
> b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.fdf
> index 7e2a8b1b9f..45460570d9 100644
> --- a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.fdf
> +++ b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.fdf
> @@ -84,7 +84,7 @@ SET gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaSize
> = 0x01000000
> SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSSize =
> 0x00040000 # Size must match WhitleyFspPkg.fdf content
> SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspMSize =
> 0x00221000 # Size must match WhitleyFspPkg.fdf content
> SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspTSize =
> 0x00006000 # Size must match WhitleyFspPkg.fdf content
> - SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvBspPreMemorySize =
> 0x00001000
> + SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvBspPreMemorySize =
> + 0x00010000
> SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPreMemorySize =
> gCpPlatFlashTokenSpaceGuid.PcdFlashFdSecPeiSize -
> gMinPlatformPkgTokenSpaceGuid.PcdFlashFvBspSize -
> gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPostMemorySize -
> gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSSize -
> gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspMSize -
> gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspTSize -
> gMinPlatformPkgTokenSpaceGuid.PcdFlashFvBspPreMemorySize
>
> #
> @@ -481,6 +481,8 @@ SET
> gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaSize = 0x01000000
> !include MinPlatformPkg/Include/Fdf/CommonSpiFvHeaderInfo.fdf
> FvNameGuid = 09f25d44-b2ef-4225-8b2e-e0e094b51775
>
> + !include AdvancedFeaturePkg/Include/PreMemory.fdf
> +
> [FV.FvBspPreMemory]
> !include MinPlatformPkg/Include/Fdf/CommonSpiFvHeaderInfo.fdf
> FvNameGuid = e6c65995-8c2d-4119-a52d-7dbf1acb45a1
> @@ -710,6 +712,8 @@ SET
> gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaSize = 0x01000000
> !include MinPlatformPkg/Include/Fdf/CommonSpiFvHeaderInfo.fdf
> FvNameGuid = 70aeaf57-4997-49ce-a4f7-122980745670
>
> + !include AdvancedFeaturePkg/Include/PostMemory.fdf
> +
> [FV.FvAdvanced]
> !include MinPlatformPkg/Include/Fdf/CommonSpiFvHeaderInfo.fdf
> FvNameGuid = f21ee7a1-53a9-453d-aee3-b6a5c25bada5
> --
> 2.27.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#85647): https://edk2.groups.io/g/devel/message/85647
Mute This Topic: https://groups.io/mt/88365352/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-