1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [PATCH V3 0/3] Rename XenTimerDxe to LocalApicTimerDxe

Min Xu posted 3 patches 2 years, 5 months ago
Failed in applying to current master (apply log)
OvmfPkg/AmdSev/AmdSevX64.dsc                          |  5 +++--
OvmfPkg/AmdSev/AmdSevX64.fdf                          |  3 +--
OvmfPkg/Microvm/MicrovmX64.dsc                        |  2 +-
OvmfPkg/Microvm/MicrovmX64.fdf                        |  2 +-
OvmfPkg/OvmfPkgIa32.dsc                               | 10 +++++++++-
OvmfPkg/OvmfPkgIa32.fdf                               |  8 ++++++--
OvmfPkg/OvmfPkgIa32X64.dsc                            | 10 +++++++++-
OvmfPkg/OvmfPkgIa32X64.fdf                            |  8 ++++++--
OvmfPkg/OvmfPkgX64.dsc                                | 10 +++++++++-
OvmfPkg/OvmfPkgX64.fdf                                |  8 ++++++--
OvmfPkg/OvmfXen.dsc                                   |  2 +-
OvmfPkg/OvmfXen.fdf                                   |  2 +-
.../LocalApicTimerDxe/LocalApicTimerDxe.c             |  7 +++----
.../LocalApicTimerDxe/LocalApicTimerDxe.h             |  4 ++--
.../LocalApicTimerDxe/LocalApicTimerDxe.inf           | 11 +++++++----
15 files changed, 65 insertions(+), 27 deletions(-)
rename OvmfPkg/XenTimerDxe/XenTimerDxe.c => UefiCpuPkg/LocalApicTimerDxe/LocalApicTimerDxe.c (95%)
rename OvmfPkg/XenTimerDxe/XenTimerDxe.h => UefiCpuPkg/LocalApicTimerDxe/LocalApicTimerDxe.h (96%)
rename OvmfPkg/XenTimerDxe/XenTimerDxe.inf => UefiCpuPkg/LocalApicTimerDxe/LocalApicTimerDxe.inf (72%)
[edk2-devel] [PATCH V3 0/3] Rename XenTimerDxe to LocalApicTimerDxe
Posted by Min Xu 2 years, 5 months ago 
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3711

XenTimerDxe is a local Apic timer driver and it has nothing to do
with Xen. So rename it to LocalApicTimerDxe.

After renaming, LocalApicTimerDxe is used in OvmfPkg if CSM_ENABLE=FALSE.
Otherwise 8254 timer is used.

Since LocalApicTimerDxe doesn't depend on OvmfPkg, so it is moved to
UefiCpuPkg.

Patch #1:
Rename XenTimerDxe to LocalApicTimerDxe

Patch #2:
Switch timer in build time for OvmfPkg. If CSM_ENABLE=TRUE, 8254 timer
is used, otherwise the timer is LocalApicTimerDxe.

Patch #3:
Move LocalApicTimerDxe from OvmfPkg to UefiCpuPkg.

Code at: https://github.com/mxu9/edk2/tree/ovmf_lapic_timer.v3

v3 changes:
 - Move LocalApicTimerDxe to UefiCpuPkg
 - Fix the errors in v2 patch-1 that OvmfXen.dsc / .fdf and
   MicrovmX64.dsc / .fdf are not updated for new name.
 - Add XenTimerDxe reviewers.

v2 changes:
 - Add gEfiMdePkgTokenSpaceGuid.PcdFSBClock in *.dsc

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Brijesh Singh <brijesh.singh@amd.com>
Cc: Erdem Aktas <erdemaktas@google.com>
Cc: James Bottomley <jejb@linux.ibm.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Min Xu <min.m.xu@intel.com>

Min Xu (3):
  OvmfPkg: Rename XenTimerDxe to LocalApicTimerDxe
  OvmfPkg: Switch timer in build time for OvmfPkg
  OvmfPkg: Move LocalApicTimerDxe to UefiCpuPkg

 OvmfPkg/AmdSev/AmdSevX64.dsc                          |  5 +++--
 OvmfPkg/AmdSev/AmdSevX64.fdf                          |  3 +--
 OvmfPkg/Microvm/MicrovmX64.dsc                        |  2 +-
 OvmfPkg/Microvm/MicrovmX64.fdf                        |  2 +-
 OvmfPkg/OvmfPkgIa32.dsc                               | 10 +++++++++-
 OvmfPkg/OvmfPkgIa32.fdf                               |  8 ++++++--
 OvmfPkg/OvmfPkgIa32X64.dsc                            | 10 +++++++++-
 OvmfPkg/OvmfPkgIa32X64.fdf                            |  8 ++++++--
 OvmfPkg/OvmfPkgX64.dsc                                | 10 +++++++++-
 OvmfPkg/OvmfPkgX64.fdf                                |  8 ++++++--
 OvmfPkg/OvmfXen.dsc                                   |  2 +-
 OvmfPkg/OvmfXen.fdf                                   |  2 +-
 .../LocalApicTimerDxe/LocalApicTimerDxe.c             |  7 +++----
 .../LocalApicTimerDxe/LocalApicTimerDxe.h             |  4 ++--
 .../LocalApicTimerDxe/LocalApicTimerDxe.inf           | 11 +++++++----
 15 files changed, 65 insertions(+), 27 deletions(-)
 rename OvmfPkg/XenTimerDxe/XenTimerDxe.c => UefiCpuPkg/LocalApicTimerDxe/LocalApicTimerDxe.c (95%)
 rename OvmfPkg/XenTimerDxe/XenTimerDxe.h => UefiCpuPkg/LocalApicTimerDxe/LocalApicTimerDxe.h (96%)
 rename OvmfPkg/XenTimerDxe/XenTimerDxe.inf => UefiCpuPkg/LocalApicTimerDxe/LocalApicTimerDxe.inf (72%)

-- 
2.29.2.windows.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#83433): https://edk2.groups.io/g/devel/message/83433
Mute This Topic: https://groups.io/mt/86900362/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH V3 0/3] Rename XenTimerDxe to LocalApicTimerDxe
Posted by Gerd Hoffmann 2 years, 5 months ago 
On Mon, Nov 08, 2021 at 02:07:57PM +0800, Min Xu wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3711
> 
> XenTimerDxe is a local Apic timer driver and it has nothing to do
> with Xen. So rename it to LocalApicTimerDxe.
> 
> After renaming, LocalApicTimerDxe is used in OvmfPkg if CSM_ENABLE=FALSE.
> Otherwise 8254 timer is used.
> 
> Since LocalApicTimerDxe doesn't depend on OvmfPkg, so it is moved to
> UefiCpuPkg.
> 
> Patch #1:
> Rename XenTimerDxe to LocalApicTimerDxe
> 
> Patch #2:
> Switch timer in build time for OvmfPkg. If CSM_ENABLE=TRUE, 8254 timer
> is used, otherwise the timer is LocalApicTimerDxe.
> 
> Patch #3:
> Move LocalApicTimerDxe from OvmfPkg to UefiCpuPkg.
> 
> Code at: https://github.com/mxu9/edk2/tree/ovmf_lapic_timer.v3
> 
> v3 changes:
>  - Move LocalApicTimerDxe to UefiCpuPkg
>  - Fix the errors in v2 patch-1 that OvmfXen.dsc / .fdf and
>    MicrovmX64.dsc / .fdf are not updated for new name.
>  - Add XenTimerDxe reviewers.
> 
> v2 changes:
>  - Add gEfiMdePkgTokenSpaceGuid.PcdFSBClock in *.dsc
> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Brijesh Singh <brijesh.singh@amd.com>
> Cc: Erdem Aktas <erdemaktas@google.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Min Xu <min.m.xu@intel.com>

Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#83486): https://edk2.groups.io/g/devel/message/83486
Mute This Topic: https://groups.io/mt/86900362/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH V3 0/3] Rename XenTimerDxe to LocalApicTimerDxe
Posted by Yao, Jiewen 2 years, 5 months ago 
Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>

> -----Original Message-----
> From: Gerd Hoffmann <kraxel@redhat.com>
> Sent: Tuesday, November 9, 2021 3:00 PM
> To: Xu, Min M <min.m.xu@intel.com>
> Cc: devel@edk2.groups.io; Ard Biesheuvel <ardb+tianocore@kernel.org>; Justen,
> Jordan L <jordan.l.justen@intel.com>; Brijesh Singh <brijesh.singh@amd.com>;
> Erdem Aktas <erdemaktas@google.com>; James Bottomley
> <jejb@linux.ibm.com>; Yao, Jiewen <jiewen.yao@intel.com>; Tom Lendacky
> <thomas.lendacky@amd.com>; Dong, Eric <eric.dong@intel.com>; Ni, Ray
> <ray.ni@intel.com>
> Subject: Re: [PATCH V3 0/3] Rename XenTimerDxe to LocalApicTimerDxe
> 
> On Mon, Nov 08, 2021 at 02:07:57PM +0800, Min Xu wrote:
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3711
> >
> > XenTimerDxe is a local Apic timer driver and it has nothing to do
> > with Xen. So rename it to LocalApicTimerDxe.
> >
> > After renaming, LocalApicTimerDxe is used in OvmfPkg if CSM_ENABLE=FALSE.
> > Otherwise 8254 timer is used.
> >
> > Since LocalApicTimerDxe doesn't depend on OvmfPkg, so it is moved to
> > UefiCpuPkg.
> >
> > Patch #1:
> > Rename XenTimerDxe to LocalApicTimerDxe
> >
> > Patch #2:
> > Switch timer in build time for OvmfPkg. If CSM_ENABLE=TRUE, 8254 timer
> > is used, otherwise the timer is LocalApicTimerDxe.
> >
> > Patch #3:
> > Move LocalApicTimerDxe from OvmfPkg to UefiCpuPkg.
> >
> > Code at: https://github.com/mxu9/edk2/tree/ovmf_lapic_timer.v3
> >
> > v3 changes:
> >  - Move LocalApicTimerDxe to UefiCpuPkg
> >  - Fix the errors in v2 patch-1 that OvmfXen.dsc / .fdf and
> >    MicrovmX64.dsc / .fdf are not updated for new name.
> >  - Add XenTimerDxe reviewers.
> >
> > v2 changes:
> >  - Add gEfiMdePkgTokenSpaceGuid.PcdFSBClock in *.dsc
> >
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Brijesh Singh <brijesh.singh@amd.com>
> > Cc: Erdem Aktas <erdemaktas@google.com>
> > Cc: James Bottomley <jejb@linux.ibm.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Tom Lendacky <thomas.lendacky@amd.com>
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Cc: Eric Dong <eric.dong@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Signed-off-by: Min Xu <min.m.xu@intel.com>
> 
> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#83488): https://edk2.groups.io/g/devel/message/83488
Mute This Topic: https://groups.io/mt/86900362/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.