[edk2-devel] [PATCH v3 0/2] ExtPkg Updates

Jeff Brasen via groups.io posted 2 patches 2 weeks ago
Failed in applying to current master (apply log)
Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h    | 14 +++++++
Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c    | 54 +++++++++++++++++++++------
Features/Ext4Pkg/Ext4Dxe/Superblock.c | 46 +++++++++++++++++++++--
3 files changed, 99 insertions(+), 15 deletions(-)

[edk2-devel] [PATCH v3 0/2] ExtPkg Updates

Posted by Jeff Brasen via groups.io 2 weeks ago
I have been using the new Ext4Pkg and been pretty successful and it is solving a use case we had.

Had a couple updates to propose

1. Changed the implementation of the binding protocol to both check if the driver is already bound
to the partition as well as added a really quick check to validate the magic value in supported.
This improves performance when you have a large number of non-ext4 partitions on the system.

2. As we are planning on using this for boot support we want to support unclean filesystem states in
case the user doesn't reset cleanly. I added a check if the recovery journal is present and if so treat
the filesystem as read-only (I know the driver is only RO at this point, but figured if you added write
support prior to recovery journal support we would want that). With this everything seems to work great.
I can add this under a FeaturePcd if desired as well.

Change log

v3 - Removed goto flow on binding supported failures
     Minor code review comments
v2 - Minor code review comments
v1 - Initial revision

Jeff Brasen (2):
  Ext4Pkg: Improve Ext4IsBindingSupported() behavior
  Ext4Pkg: Support uncleanly unmounted filesystems

 Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h    | 14 +++++++
 Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c    | 54 +++++++++++++++++++++------
 Features/Ext4Pkg/Ext4Dxe/Superblock.c | 46 +++++++++++++++++++++--
 3 files changed, 99 insertions(+), 15 deletions(-)

-- 
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#80510): https://edk2.groups.io/g/devel/message/80510
Mute This Topic: https://groups.io/mt/85521567/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH v3 0/2] ExtPkg Updates

Posted by Pedro Falcato 2 weeks ago
Pushed as to edk2-platforms as
71f334393361d53e805fe9a01e2cf7bc43e909ce and
7872c983ed45de4c9e4e9295aa249e1369913094, respectively.

On Fri, Sep 10, 2021 at 11:11 PM Jeff Brasen <jbrasen@nvidia.com> wrote:
>
> I have been using the new Ext4Pkg and been pretty successful and it is solving a use case we had.
>
> Had a couple updates to propose
>
> 1. Changed the implementation of the binding protocol to both check if the driver is already bound
> to the partition as well as added a really quick check to validate the magic value in supported.
> This improves performance when you have a large number of non-ext4 partitions on the system.
>
> 2. As we are planning on using this for boot support we want to support unclean filesystem states in
> case the user doesn't reset cleanly. I added a check if the recovery journal is present and if so treat
> the filesystem as read-only (I know the driver is only RO at this point, but figured if you added write
> support prior to recovery journal support we would want that). With this everything seems to work great.
> I can add this under a FeaturePcd if desired as well.
>
> Change log
>
> v3 - Removed goto flow on binding supported failures
>      Minor code review comments
> v2 - Minor code review comments
> v1 - Initial revision
>
> Jeff Brasen (2):
>   Ext4Pkg: Improve Ext4IsBindingSupported() behavior
>   Ext4Pkg: Support uncleanly unmounted filesystems
>
>  Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h    | 14 +++++++
>  Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c    | 54 +++++++++++++++++++++------
>  Features/Ext4Pkg/Ext4Dxe/Superblock.c | 46 +++++++++++++++++++++--
>  3 files changed, 99 insertions(+), 15 deletions(-)
>
> --
> 2.17.1
>


-- 
Pedro Falcato


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#80519): https://edk2.groups.io/g/devel/message/80519
Mute This Topic: https://groups.io/mt/85521567/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH v3 0/2] ExtPkg Updates

Posted by Pedro Falcato 2 weeks ago
Series Reviewed-by: Pedro Falcato <pedro.falcato@gmail.com>

On Fri, Sep 10, 2021 at 11:11 PM Jeff Brasen <jbrasen@nvidia.com> wrote:
>
> I have been using the new Ext4Pkg and been pretty successful and it is solving a use case we had.
>
> Had a couple updates to propose
>
> 1. Changed the implementation of the binding protocol to both check if the driver is already bound
> to the partition as well as added a really quick check to validate the magic value in supported.
> This improves performance when you have a large number of non-ext4 partitions on the system.
>
> 2. As we are planning on using this for boot support we want to support unclean filesystem states in
> case the user doesn't reset cleanly. I added a check if the recovery journal is present and if so treat
> the filesystem as read-only (I know the driver is only RO at this point, but figured if you added write
> support prior to recovery journal support we would want that). With this everything seems to work great.
> I can add this under a FeaturePcd if desired as well.
>
> Change log
>
> v3 - Removed goto flow on binding supported failures
>      Minor code review comments
> v2 - Minor code review comments
> v1 - Initial revision
>
> Jeff Brasen (2):
>   Ext4Pkg: Improve Ext4IsBindingSupported() behavior
>   Ext4Pkg: Support uncleanly unmounted filesystems
>
>  Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h    | 14 +++++++
>  Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c    | 54 +++++++++++++++++++++------
>  Features/Ext4Pkg/Ext4Dxe/Superblock.c | 46 +++++++++++++++++++++--
>  3 files changed, 99 insertions(+), 15 deletions(-)
>
> --
> 2.17.1
>


-- 
Pedro Falcato


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#80518): https://edk2.groups.io/g/devel/message/80518
Mute This Topic: https://groups.io/mt/85521567/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-