[edk2-devel] [PATCH v9 22/46] OvmfPkg/VmgExitLib: Add support for VMMCALL NAE events

Lendacky, Thomas posted 46 patches 5 years, 8 months ago
There is a newer version of this series
[edk2-devel] [PATCH v9 22/46] OvmfPkg/VmgExitLib: Add support for VMMCALL NAE events
Posted by Lendacky, Thomas 5 years, 8 months ago
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198

Under SEV-ES, a VMMCALL intercept generates a #VC exception. VMGEXIT must
be used to allow the hypervisor to handle this intercept.

Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Acked-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
---
 OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c | 48 ++++++++++++++++++++
 1 file changed, 48 insertions(+)

diff --git a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c b/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c
index 9419651fea2e..b77821d2f989 100644
--- a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c
+++ b/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c
@@ -879,6 +879,50 @@ WbinvdExit (
   return VmgExit (Ghcb, SVM_EXIT_WBINVD, 0, 0);

 }

 

+/**

+  Handle a VMMCALL event.

+

+  Use the VMGEXIT instruction to handle a VMMCALL event.

+

+  @param[in, out] Ghcb             Pointer to the Guest-Hypervisor Communication

+                                   Block

+  @param[in, out] Regs             x64 processor context

+  @param[in]      InstructionData  Instruction parsing context

+

+  @return 0                        Event handled successfully

+  @return Others                   New exception value to propagate

+

+**/

+STATIC

+UINT64

+VmmCallExit (

+  IN OUT GHCB                     *Ghcb,

+  IN OUT EFI_SYSTEM_CONTEXT_X64   *Regs,

+  IN     SEV_ES_INSTRUCTION_DATA  *InstructionData

+  )

+{

+  UINT64  Status;

+

+  DecodeModRm (Regs, InstructionData);

+

+  Ghcb->SaveArea.Rax = Regs->Rax;

+  GhcbSetRegValid (Ghcb, GhcbRax);

+  Ghcb->SaveArea.Cpl = (UINT8) (Regs->Cs & 0x3);

+  GhcbSetRegValid (Ghcb, GhcbCpl);

+

+  Status = VmgExit (Ghcb, SVM_EXIT_VMMCALL, 0, 0);

+  if (Status != 0) {

+    return Status;

+  }

+

+  if (!GhcbIsRegValid (Ghcb, GhcbRax)) {

+    return UnsupportedExit (Ghcb, Regs, InstructionData);

+  }

+  Regs->Rax = Ghcb->SaveArea.Rax;

+

+  return 0;

+}

+

 /**

   Handle an MSR event.

 

@@ -1393,6 +1437,10 @@ VmgExitHandleVc (
     NaeExit = MsrExit;

     break;

 

+  case SVM_EXIT_VMMCALL:

+    NaeExit = VmmCallExit;

+    break;

+

   case SVM_EXIT_WBINVD:

     NaeExit = WbinvdExit;

     break;

-- 
2.27.0


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#60792): https://edk2.groups.io/g/devel/message/60792
Mute This Topic: https://groups.io/mt/74692435/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v9 22/46] OvmfPkg/VmgExitLib: Add support for VMMCALL NAE events
Posted by Laszlo Ersek 5 years, 8 months ago
On 06/05/20 15:27, Tom Lendacky wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198
> 
> Under SEV-ES, a VMMCALL intercept generates a #VC exception. VMGEXIT must
> be used to allow the hypervisor to handle this intercept.
> 
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Acked-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
>  OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c | 48 ++++++++++++++++++++
>  1 file changed, 48 insertions(+)

looks OK


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#61126): https://edk2.groups.io/g/devel/message/61126
Mute This Topic: https://groups.io/mt/74692435/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-