[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 0/3] Manifest parser cleanup

Bjorge, Erik C posted 3 patches 3 years, 11 months ago
Failed in applying to current master (apply log)
edkrepo_manifest_parser/edk_manifest.py | 249 +++++++++++++-----------
1 file changed, 139 insertions(+), 110 deletions(-)
[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 0/3] Manifest parser cleanup
Posted by Bjorge, Erik C 3 years, 11 months ago
General cleanup of the manifest parser and minor improvements to make
the code more flexible.

Cc: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>

Erik Bjorge (3):
  EdkRepo: Flake8 cleanup
  EdkRepo: Improve error message with invalid XML
  EdkRepo: Refactoring private class members

 edkrepo_manifest_parser/edk_manifest.py | 249 +++++++++++++-----------
 1 file changed, 139 insertions(+), 110 deletions(-)

-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#58483): https://edk2.groups.io/g/devel/message/58483
Mute This Topic: https://groups.io/mt/73386937/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 0/3] Manifest parser cleanup
Posted by Nate DeSimone 3 years, 11 months ago
For the series...

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: Bjorge, Erik C <erik.c.bjorge@intel.com> 
Sent: Thursday, April 30, 2020 3:53 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E <ashley.e.desimone@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince <prince.agyeman@intel.com>
Subject: [edk2-staging/EdkRepo] [PATCH v1 0/3] Manifest parser cleanup

General cleanup of the manifest parser and minor improvements to make the code more flexible.

Cc: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>

Erik Bjorge (3):
  EdkRepo: Flake8 cleanup
  EdkRepo: Improve error message with invalid XML
  EdkRepo: Refactoring private class members

 edkrepo_manifest_parser/edk_manifest.py | 249 +++++++++++++-----------
 1 file changed, 139 insertions(+), 110 deletions(-)

--
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#58595): https://edk2.groups.io/g/devel/message/58595
Mute This Topic: https://groups.io/mt/73386937/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 0/3] Manifest parser cleanup
Posted by Nate DeSimone 3 years, 11 months ago
After a some rebasing pain... Pushed as f2f6f5a2~.. 6153e4a2

-----Original Message-----
From: Bjorge, Erik C <erik.c.bjorge@intel.com> 
Sent: Thursday, April 30, 2020 3:53 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E <ashley.e.desimone@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince <prince.agyeman@intel.com>
Subject: [edk2-staging/EdkRepo] [PATCH v1 0/3] Manifest parser cleanup

General cleanup of the manifest parser and minor improvements to make the code more flexible.

Cc: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>

Erik Bjorge (3):
  EdkRepo: Flake8 cleanup
  EdkRepo: Improve error message with invalid XML
  EdkRepo: Refactoring private class members

 edkrepo_manifest_parser/edk_manifest.py | 249 +++++++++++++-----------
 1 file changed, 139 insertions(+), 110 deletions(-)

--
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#58596): https://edk2.groups.io/g/devel/message/58596
Mute This Topic: https://groups.io/mt/73386937/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 0/3] Manifest parser cleanup
Posted by Bjorge, Erik C 3 years, 11 months ago
Nate, if you run into this issue again please let me know and I can send out a new version.

Thanks,
-Erik

-----Original Message-----
From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com> 
Sent: Monday, May 4, 2020 8:59 PM
To: Bjorge, Erik C <erik.c.bjorge@intel.com>; devel@edk2.groups.io
Cc: Desimone, Ashley E <ashley.e.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince <prince.agyeman@intel.com>
Subject: RE: [edk2-staging/EdkRepo] [PATCH v1 0/3] Manifest parser cleanup

After a some rebasing pain... Pushed as f2f6f5a2~.. 6153e4a2

-----Original Message-----
From: Bjorge, Erik C <erik.c.bjorge@intel.com> 
Sent: Thursday, April 30, 2020 3:53 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E <ashley.e.desimone@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince <prince.agyeman@intel.com>
Subject: [edk2-staging/EdkRepo] [PATCH v1 0/3] Manifest parser cleanup

General cleanup of the manifest parser and minor improvements to make the code more flexible.

Cc: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>

Erik Bjorge (3):
  EdkRepo: Flake8 cleanup
  EdkRepo: Improve error message with invalid XML
  EdkRepo: Refactoring private class members

 edkrepo_manifest_parser/edk_manifest.py | 249 +++++++++++++-----------
 1 file changed, 139 insertions(+), 110 deletions(-)

--
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#58653): https://edk2.groups.io/g/devel/message/58653
Mute This Topic: https://groups.io/mt/73386937/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-