[v3] Move FIT based microcode shadow to platform PEIM

[edk2-devel] [PATCH v3 0/2] Move FIT based microcode shadow to platform PEIM

Siyuan, Fu posted 2 patches 4 years, 2 months ago

Diff against v2
Download series mbox

Failed in applying to current master (apply log)

.../IndustryStandard/FirmwareInterfaceTable.h |  76 -------------
UefiCpuPkg/Include/Ppi/ShadowMicrocode.h      |  66 +++++++++++
UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf |   1 -
UefiCpuPkg/Library/MpInitLib/DxeMpLib.c       |  26 ++++-
UefiCpuPkg/Library/MpInitLib/Microcode.c      | 105 +-----------------
UefiCpuPkg/Library/MpInitLib/MpLib.h          |  19 +++-
UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf |   4 +-
UefiCpuPkg/Library/MpInitLib/PeiMpLib.c       |  68 ++++++++++++
UefiCpuPkg/UefiCpuPkg.dec                     |  11 +-
UefiCpuPkg/UefiCpuPkg.uni                     |   6 -
10 files changed, 183 insertions(+), 199 deletions(-)
delete mode 100644 MdePkg/Include/IndustryStandard/FirmwareInterfaceTable.h
create mode 100644 UefiCpuPkg/Include/Ppi/ShadowMicrocode.h

Expand all Fold all

[edk2-devel] [PATCH v3 0/2] Move FIT based microcode shadow to platform PEIM

Posted by Siyuan, Fu 4 years, 2 months ago

V2 Changes:
Rename EDKII_PEI_CPU_MICROCODE_ID to EDKII_PEI_MICROCODE_CPU_ID.
Return EFI_UNSUPPORTED instead of EFI_NOT_FOUND if no platform
microcode shadow PPI/Protocol is found.
Remove PcdCpuShadowMicrocodeByFit related tokens from UefiCpuPkg.uni
V3 Changes
Add comments to DXE version PlatformShadowMicrocode().

Commit c7c964b and dd01704 add header file for FIT table and update
MpInitLib to support FIT based microcode shadow operation. There are
comments that FIT is Intel specific specification instead of industry
standard, which should not be placed in EDK2 MdePkg and UefiCpuPkg.
So this patch adds a platform PPI for the microcode shadow logic, and
remove the FIT related code from EDK2.
The FIT based microcode shadow support will be implemented as a new
platform PEIM in IntelSiliconPkg in edk2-platforms.
This patch doesn't provide a DXE version shadow microcode protocol,
a platform which only uses DxeMpInitLib instance only supports PCD
based microcode shadowing.

A detailed design doc can be found here:
https://edk2.groups.io/g/devel/files/Designs/2020/0214/Support%20
the%202nd%20Microcode%20FV%20Flash%20Region.pdf

[Patch 1/2] UefiCpuPkg: Remove FIT based microcode shadow logic from
 MpInitLib.
[Patch 2/2] MdePkg: Remove FIT table industry standard header file.

Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>

Siyuan Fu (2):
  UefiCpuPkg: Remove FIT based microcode shadow logic from MpInitLib.
  MdePkg: Remove FIT table industry standard header file.

 .../IndustryStandard/FirmwareInterfaceTable.h |  76 -------------
 UefiCpuPkg/Include/Ppi/ShadowMicrocode.h      |  66 +++++++++++
 UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf |   1 -
 UefiCpuPkg/Library/MpInitLib/DxeMpLib.c       |  26 ++++-
 UefiCpuPkg/Library/MpInitLib/Microcode.c      | 105 +-----------------
 UefiCpuPkg/Library/MpInitLib/MpLib.h          |  19 +++-
 UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf |   4 +-
 UefiCpuPkg/Library/MpInitLib/PeiMpLib.c       |  68 ++++++++++++
 UefiCpuPkg/UefiCpuPkg.dec                     |  11 +-
 UefiCpuPkg/UefiCpuPkg.uni                     |   6 -
 10 files changed, 183 insertions(+), 199 deletions(-)
 delete mode 100644 MdePkg/Include/IndustryStandard/FirmwareInterfaceTable.h
 create mode 100644 UefiCpuPkg/Include/Ppi/ShadowMicrocode.h

-- 
2.19.1.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#54326): https://edk2.groups.io/g/devel/message/54326
Mute This Topic: https://groups.io/mt/71230471/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-