BaseTools: remove or change un-needed variables

[edk2] [PATCH v1 0/5] BaseTools: remove or change un-needed variables

Jaben Carsey posted 5 patches 6 years, 6 months ago

Download series mbox

Failed in applying to current master (apply log)

BaseTools/Source/Python/AutoGen/AutoGen.py        | 26 ++++-------
BaseTools/Source/Python/AutoGen/GenC.py           | 48 +++++++++++---------
BaseTools/Source/Python/AutoGen/GenVar.py         | 15 +++---
BaseTools/Source/Python/Common/Misc.py            |  2 +-
BaseTools/Source/Python/Workspace/DscBuildData.py | 38 ++++++++--------
5 files changed, 63 insertions(+), 66 deletions(-)

Expand all Fold all

[edk2] [PATCH v1 0/5] BaseTools: remove or change un-needed variables

Posted by Jaben Carsey 6 years, 6 months ago

use sets instead of lists when doing only "in" testing later
use counts instead of lists when they just get counted after

Jaben Carsey (5):
  BaseTools: use existing shared variable
  BaseTools: no need to save the data
  BaseTools: skip updating temporary variable.
  BaseTools: use set instead of list for a variable to be used with in
  BaseTools: reduce list usage when not needed

 BaseTools/Source/Python/AutoGen/AutoGen.py        | 26 ++++-------
 BaseTools/Source/Python/AutoGen/GenC.py           | 48 +++++++++++---------
 BaseTools/Source/Python/AutoGen/GenVar.py         | 15 +++---
 BaseTools/Source/Python/Common/Misc.py            |  2 +-
 BaseTools/Source/Python/Workspace/DscBuildData.py | 38 ++++++++--------
 5 files changed, 63 insertions(+), 66 deletions(-)

-- 
2.16.2.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v1 0/5] BaseTools: remove or change un-needed variables

Posted by Zhu, Yonghong 6 years, 6 months ago

Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 

Best Regards,
Zhu Yonghong


-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jaben Carsey
Sent: Wednesday, April 11, 2018 7:17 AM
To: edk2-devel@lists.01.org
Subject: [edk2] [PATCH v1 0/5] BaseTools: remove or change un-needed variables

use sets instead of lists when doing only "in" testing later use counts instead of lists when they just get counted after

Jaben Carsey (5):
  BaseTools: use existing shared variable
  BaseTools: no need to save the data
  BaseTools: skip updating temporary variable.
  BaseTools: use set instead of list for a variable to be used with in
  BaseTools: reduce list usage when not needed

 BaseTools/Source/Python/AutoGen/AutoGen.py        | 26 ++++-------
 BaseTools/Source/Python/AutoGen/GenC.py           | 48 +++++++++++---------
 BaseTools/Source/Python/AutoGen/GenVar.py         | 15 +++---
 BaseTools/Source/Python/Common/Misc.py            |  2 +-
 BaseTools/Source/Python/Workspace/DscBuildData.py | 38 ++++++++--------
 5 files changed, 63 insertions(+), 66 deletions(-)

--
2.16.2.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel