[edk2] [PATCH v1 03/10] BaseTools: Eot tool never populates this dictionary

Jaben Carsey posted 10 patches 6 years, 7 months ago
[edk2] [PATCH v1 03/10] BaseTools: Eot tool never populates this dictionary
Posted by Jaben Carsey 6 years, 7 months ago
we initialize this dict and then check it's contents, but never add items.
we can remove it without any effect.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
---
 BaseTools/Source/Python/Eot/Eot.py           | 8 --------
 BaseTools/Source/Python/Eot/EotGlobalData.py | 4 ----
 2 files changed, 12 deletions(-)

diff --git a/BaseTools/Source/Python/Eot/Eot.py b/BaseTools/Source/Python/Eot/Eot.py
index c4164199acf3..45c97bb258f2 100644
--- a/BaseTools/Source/Python/Eot/Eot.py
+++ b/BaseTools/Source/Python/Eot/Eot.py
@@ -340,14 +340,6 @@ class Eot(object):
             GuidMacro2 = ''
             GuidValue = ''
 
-            # Find value for hardcode guid macro
-            if GuidName in EotGlobalData.gGuidMacroDict:
-                GuidMacro = EotGlobalData.gGuidMacroDict[GuidName][0]
-                GuidValue = EotGlobalData.gGuidMacroDict[GuidName][1]
-                SqlCommand = """update Report set GuidMacro = '%s', GuidValue = '%s' where GuidName = '%s'""" %(GuidMacro, GuidValue, GuidName)
-                EotGlobalData.gDb.TblReport.Exec(SqlCommand)
-                continue
-
             # Find guid value defined in Dec file
             if GuidName in EotGlobalData.gGuidDict:
                 GuidValue = EotGlobalData.gGuidDict[GuidName]
diff --git a/BaseTools/Source/Python/Eot/EotGlobalData.py b/BaseTools/Source/Python/Eot/EotGlobalData.py
index a4654853ab5e..dea4206e9d48 100644
--- a/BaseTools/Source/Python/Eot/EotGlobalData.py
+++ b/BaseTools/Source/Python/Eot/EotGlobalData.py
@@ -72,10 +72,6 @@ gOP_SOURCE_FILES = open(gSOURCE_FILES, 'w+')
 # Dict for GUID found in DEC files
 gGuidDict = dict()
 
-# Dict for hard coded GUID Macros
-# {GuidName : [GuidMacro : GuidValue]}
-gGuidMacroDict = sdict()
-
 # Dict for PPI
 gPpiList = {}
 
-- 
2.16.2.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel