BaseTools: Fix the improper error logging

[edk2-devel] [PATCH] BaseTools: Fix the improper error logging

Posted by Irene Park 5 years, 1 month ago

From: Irene Park <ipark@nvidia.com>

EdkLogger.ERROR() was replaced with EdkLogger.error() to deliver the
expected error message when an error occurs.

Signed-off-by: Irene Park <ipark@nvidia.com>

---
 BaseTools/Source/Python/AutoGen/GenPcdDb.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Source/Python/AutoGen/GenPcdDb.py b/BaseTools/Source/Python/AutoGen/GenPcdDb.py
index 0870c44..ad5dae0 100644
--- a/BaseTools/Source/Python/AutoGen/GenPcdDb.py
+++ b/BaseTools/Source/Python/AutoGen/GenPcdDb.py
@@ -894,7 +894,7 @@ def CreatePcdDataBase(PcdDBData):
     delta = {}
     for skuname, skuid in PcdDBData:
         if len(PcdDBData[(skuname, skuid)][1]) != len(PcdDBData[(TAB_DEFAULT, "0")][1]):
-            EdkLogger.ERROR("The size of each sku in one pcd are not same")
+            EdkLogger.error("build", AUTOGEN_ERROR, "The size of each sku in one pcd are not same")
     for skuname, skuid in PcdDBData:
         if skuname == TAB_DEFAULT:
             continue
-- 
2.7.4



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#69492): https://edk2.groups.io/g/devel/message/69492
Mute This Topic: https://groups.io/mt/79283023/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] 回复: [PATCH] BaseTools: Fix the improper error logging

Posted by gaoliming 5 years, 1 month ago

Good catch. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: Name <ipark@nvidia.com>
> 发送时间: 2020年12月29日 9:47
> 收件人: devel@edk2.groups.io; bob.c.feng@intel.com;
> gaoliming@byosoft.com.cn
> 抄送: Irene Park <ipark@nvidia.com>
> 主题: [PATCH] BaseTools: Fix the improper error logging
> 
> From: Irene Park <ipark@nvidia.com>
> 
> EdkLogger.ERROR() was replaced with EdkLogger.error() to deliver the
> expected error message when an error occurs.
> 
> Signed-off-by: Irene Park <ipark@nvidia.com>
> 
> ---
>  BaseTools/Source/Python/AutoGen/GenPcdDb.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/BaseTools/Source/Python/AutoGen/GenPcdDb.py
> b/BaseTools/Source/Python/AutoGen/GenPcdDb.py
> index 0870c44..ad5dae0 100644
> --- a/BaseTools/Source/Python/AutoGen/GenPcdDb.py
> +++ b/BaseTools/Source/Python/AutoGen/GenPcdDb.py
> @@ -894,7 +894,7 @@ def CreatePcdDataBase(PcdDBData):
>      delta = {}
>      for skuname, skuid in PcdDBData:
>          if len(PcdDBData[(skuname, skuid)][1]) !=
> len(PcdDBData[(TAB_DEFAULT, "0")][1]):
> -            EdkLogger.ERROR("The size of each sku in one pcd are not
> same")
> +            EdkLogger.error("build", AUTOGEN_ERROR, "The size of each
> sku in one pcd are not same")
>      for skuname, skuid in PcdDBData:
>          if skuname == TAB_DEFAULT:
>              continue
> --
> 2.7.4





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#69519): https://edk2.groups.io/g/devel/message/69519
Mute This Topic: https://groups.io/mt/79415001/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] BaseTools: Fix the improper error logging

Posted by Bob Feng 5 years, 1 month ago

Reviewed-by: Bob Feng <bob.c.feng@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Irene Park
Sent: Tuesday, December 29, 2020 9:47 AM
To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>; gaoliming@byosoft.com.cn
Cc: Irene Park <ipark@nvidia.com>
Subject: [edk2-devel] [PATCH] BaseTools: Fix the improper error logging

From: Irene Park <ipark@nvidia.com>

EdkLogger.ERROR() was replaced with EdkLogger.error() to deliver the expected error message when an error occurs.

Signed-off-by: Irene Park <ipark@nvidia.com>

---
 BaseTools/Source/Python/AutoGen/GenPcdDb.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Source/Python/AutoGen/GenPcdDb.py b/BaseTools/Source/Python/AutoGen/GenPcdDb.py
index 0870c44..ad5dae0 100644
--- a/BaseTools/Source/Python/AutoGen/GenPcdDb.py
+++ b/BaseTools/Source/Python/AutoGen/GenPcdDb.py
@@ -894,7 +894,7 @@ def CreatePcdDataBase(PcdDBData):
     delta = {}
     for skuname, skuid in PcdDBData:
         if len(PcdDBData[(skuname, skuid)][1]) != len(PcdDBData[(TAB_DEFAULT, "0")][1]):
-            EdkLogger.ERROR("The size of each sku in one pcd are not same")
+            EdkLogger.error("build", AUTOGEN_ERROR, "The size of each 
+ sku in one pcd are not same")
     for skuname, skuid in PcdDBData:
         if skuname == TAB_DEFAULT:
             continue
--
2.7.4








-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#69527): https://edk2.groups.io/g/devel/message/69527
Mute This Topic: https://groups.io/mt/79283023/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-